In D18411#391858, @ml_vishwin.info wrote:

In D18411#391857, @jbeich wrote:

If armv7 bustage isn't a regression from 0.36.0 update then it should be in a separate bug/review.

Considering.

Have you tried -Wl,-z,notext (a la rP484698)?

Second item tried after CFLAGS+=-fPIC; replace the above error output's can't create dynamic relocation R_ARM_V4BX with unrecognised reloc 40; same addresses as well.

Looks good as is

In reply to the pkg-plist question around summary, plist should be in it's own file as it is more than 6 files.

In D17353#370102, @0mp wrote:

@ndowens_yahoo.com, apart from that, is everything ok? :)

Ah ok. Didn't know that.

Supposedly it will also run on mips64 but I currently dont have a mips64 jail to build on; which I guess I will create now

In D17019#363993, @fernape wrote:

In D17019#363958, @egypcio_googlemail.com wrote:

In D17019#363901, @ndowens_yahoo.com wrote:

In D17019#363374, @fernape wrote:

The port is amd64 only because it depends on devel/gnu-efi that is 64 bit only. That's at least on FreeBSD because the upstream project does not say they don't support ia32 (in fact, according to the Makefile, they do).

The override ARCHpart is because $ARCH is "amd64" in FreeBSD but the Makefile expects to check against "x86_64" as it is often reported in Linux.

I got gnu-efi to build on my 12-i386 poudriere jail
Though have to play with plist because the names will change according to arch

Got rid of USE_GCC line as well

should we try to change the port til this point, or create an equivalent version for i386?

I would, when ready, update devel/shim. If anyone is interested in making devel/gnu-efi work in archs other than amd64, I would open a different review.

In D17019#363374, @fernape wrote:

The port is amd64 only because it depends on devel/gnu-efi that is 64 bit only. That's at least on FreeBSD because the upstream project does not say they don't support ia32 (in fact, according to the Makefile, they do).

The override ARCHpart is because $ARCH is "amd64" in FreeBSD but the Makefile expects to check against "x86_64" as it is often reported in Linux.

@tobik As you may know, I can't commit :)

Seems this is no longer needed? Just seen a commit of one similar

In D16978#363146, @tobik wrote:

Why did you abandon this?

@tobik Thanks, taught me a few things here

Updating D17038: net/ss5: Fix missing @sample(s) in plist
Use DISTVERSION, remove extra file listing in plist

The difference in patches is because i converted the patches to proper way: make patch then make makepatches

Updating D16978: multimedia/gxine: Remove dependency that no longer exists, other cleanup
Re-add lld_unsafe
Remove gnome option

Updating D16978: multimedia/gxine: Remove dependency that no longer exists, other cleanup
Fix typo in license file
remove cpp and ldflags
remove post-install block

Updating D16978: multimedia/gxine
Add NLS knob to remove gettext as a must dep

X11/eaglemode didn’t build on 12. I’ll work on that one next

Update after starting with clean ports it worked

In D16840#361685, @tobik wrote:

In D16840#361683, @ndowens_yahoo.com wrote:

In D16840#361662, @tobik wrote:

In D16840#361661, @ndowens_yahoo.com wrote:

Patches aren’t applying cleanly for me after this revision

Can you provide more details please?

https://gist.github.com/f4482b503c89ac347543de49e393ba68

There seems to be some left over files and other unclean state in your ports tree checkout:

===>   Ignoring patchfile patch-configure.orig
===>   Ignoring patchfile patch-include-xine-xineutils.h.orig
===>   Ignoring patchfile patch-include_config.h.orig
Ignoring previously applied (or reversed) patch.
1 out of 1 hunks ignored--saving rejects to src/libw32dll/wine/registry.c.rej
Ignoring previously applied (or reversed) patch.
=> FreeBSD patch patch-src_libw32dll_wine_registry.c failed to apply cleanly.

How did you apply it? I'd suggest to cleanup the previous attempt and use svn patch D16840.diff or patch -E -V none -i D16840.diff.

In D16840#361683, @ndowens_yahoo.com wrote:

In D16840#361662, @tobik wrote:

In D16840#361661, @ndowens_yahoo.com wrote:

Patches aren’t applying cleanly for me after this revision

Can you provide more details please?

https://gist.github.com/f4482b503c89ac347543de49e393ba68

In D16840#361662, @tobik wrote:

In D16840#361661, @ndowens_yahoo.com wrote:

Patches aren’t applying cleanly for me after this revision

Can you provide more details please?

Patches aren’t applying cleanly for me after this revision

In D16840#361623, @tobik wrote:

• Add W32DLL i386-only option to properly handle the w32dll and qt plugins
• Readd files/patch-include-xine-xineutils.h to fix the build of multimedia/phonon-xine
• Remove unrecognized configure args
• Add missing multimedia/xine and multimedia/vdr-plugin-xineliboutput PLUGINSDIR bumps
• Add multimedia/gxine plist fix from D16854 (w/o the additional changes to keep it minimal here)

Test build on 10.4/i386 was fine, others still pending.

For the record these are the ports that depend on libxine

# Build with `OPTIONS_SET+=XINE LIBXINE` in make.conf
devel/efl
graphics/opencv
graphics/osg-devel
graphics/osg
graphics/gimageview
x11/eaglemode
audio/atunes
www/npapi-xine
multimedia/phonon-xine
multimedia/quark
multimedia/k9copy-kde4
multimedia/gxine
multimedia/vdr-plugin-xineliboutput
multimedia/subtitlecomposer-kde4
multimedia/xine

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Found out that w32codecs build on i386 but not possible on amd64 as there is no /usr/local/bin/win32/
Edited to fix plist issue for either/or

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Finished correcting configure patch

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Fixed messed up configure patch

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Fixed plist; Added w32codec option, is a must in order to avoid plist issue on i386(seems only builds if i386)

I got figure out what’s going on. On amd64 no pkg-list issue but on i386 there are orphaned pkgs. The only way I can think that may work is add something like if i386 plist”” else “@comment”

@tobik. Oh yea I took out vidix because when I looked at it previously I could not port the needed dep as it was too linux-centric and we don’t have the dep needed. So removed it from this coming update

In D16840#361389, @tobik wrote:

Build fails on 11.1/i386 in a different way too. Adding this patch from OpenBSD ports fixes it: https://raw.githubusercontent.com/openbsd/ports/master/multimedia/xine-lib/patches/patch-include_config_h

In file included from memcpy.c:36:
../../include/config.h:31:10: warning: "configure did not detect ARCH_X86_X32!" [-W#warnings]
#        warning "configure did not detect ARCH_X86_X32!"
         ^
memcpy.c:464:7: error: invalid operand for instruction
      BUMPPTR("64","0")
      ^
memcpy.c:145:34: note: expanded from macro 'BUMPPTR'
#  define BUMPPTR(offs,num)   "\n\tleaq\t"offs"(%q"num"), %q"num
                                 ^
<inline asm>:14:17: note: instantiated into assembly here
        leaq    64(%esi), %esi
                          ^~~~
memcpy.c:469:7: error: invalid operand for instruction
      BUMPPTR("64","1")
      ^
memcpy.c:145:34: note: expanded from macro 'BUMPPTR'
#  define BUMPPTR(offs,num)   "\n\tleaq\t"offs"(%q"num"), %q"num
                                 ^
<inline asm>:19:17: note: instantiated into assembly here
        leaq    64(%edi), %edi
                          ^~~~

Wow this port is a pain. Currently testing 11-386 but it’s building reps atm. Sorry for all the mistakes previously popping back up. I randomly rollback ports to clean up and thought my diff stored elsewhere was up2date but wasn’t. Started pulling patch using arc lately to try and avoid as much as possible

Will upload once I test again

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Added Option for ipv6 while here, Added sndio for Tobik, fixed plist white-space; DVB option also added

Done, hope this is the last time of editing :) . Will upload updated one soon after testing

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Remove lld_unsafe comment

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Fixed plist ordering, per Mat

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Sorted pkg-plist using vim :sort

In D16896#360150, @mat wrote:

I disagree with this change. We support submitting new ports using shar, so it needs to be documented.

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Revised to use suggested changes

In D16890#360009, @tobik wrote:

In D16890#360005, @ndowens_yahoo.com wrote:

I just started to work on this. I'm getting Either /usr/ports/databases/mantis/distinfo is out of date, or

> mantisbt-plugins-Activity-99cf873396ebc3fec431c6746dae1a604768f322_GH0.tar.gz is spelled incorrectly. and suspect it will do so on the other plugins as well. I did make makesum as well

How did you apply the diff from this review? I cannot reproduce this.

I just started to work on this. I'm getting Either /usr/ports/databases/mantis/distinfo is out of date, or

> mantisbt-plugins-Activity-99cf873396ebc3fec431c6746dae1a604768f322_GH0.tar.gz is spelled incorrectly. and suspect it will do so on the other plugins as well. I did make makesum as well

Updating D16854: multimedia/gxine: Fixed PLIST issue; Change on/off options
Updated with mat's suggestions

Seems to have been fixed now, closing

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Removed VIDIX Option, can not port package needed to enable it due to it being too Linux'ified

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Fixed missing \ in one of ${REINPLACE_CMD}

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
The "D" in DOCS got cut off, fixed

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Forgot to remove sed pkgconfig

Updating D16840: multimedia/libxine: Update to 1.2.9; fix options; unmark broken
Update with review fixes

Fixed most of the mentioned stuff. Will submit updated diff ASAP

In D16840#358653, @tobik wrote:

What test builds did you do? All options on, all options off, default options?

All and none

Updating D16840: multimedia/libxine
Removed Broken: Built fine on poudriere
arm64

Updating D16840: multimedia/libxine
fixed space after jpeg; fixed options;
added DOCS option