Paths

Table of Contentst

Differential D18042

devel/tortoisehg: Update to 4.8.
ClosedPublic
Actions

Authored by arrowd on Nov 19 2018, 10:56 AM.

Tags

None

Referenced Files

	F154764831: D18042.id50594.diff
	Wed, Apr 29, 9:48 AM

	Unknown Object (File)
	Tue, Apr 28, 2:42 AM

	Unknown Object (File)
	Sun, Apr 26, 10:23 PM

	Unknown Object (File)
	Sat, Apr 25, 1:06 AM

	Unknown Object (File)
	Fri, Apr 24, 2:49 PM

	Unknown Object (File)
	Sun, Apr 19, 8:47 PM

	Unknown Object (File)
	Sun, Apr 19, 7:47 AM

	Unknown Object (File)
	Sun, Apr 19, 3:17 AM

Subscribers

ndowens_yahoo.com

Details

Reviewers

Group Reviewers

Contributor Reviewers (ports)

Commits

rP485649: devel/tortoisehg: Update to 4.8.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 20889
Build 20258: arc lint + arc unit

Event Timeline

arrowd created this revision.Nov 19 2018, 10:56 AM

Harbormaster completed remote builds in B20889: Diff 50594.Nov 19 2018, 10:56 AM

ndowens_yahoo.com added a subscriber: ndowens_yahoo.com.Nov 20 2018, 4:39 AM

ndowens_yahoo.com added inline comments.

devel/tortoisehg/Makefile
18	Move OPTIONS block below NO_ARCH Nothing should go be below OPTIONS block
24	Move/keep in OPTIONS block
28	Move this under USES or move INSTALLS_ICONS down one line below this one

You can find the documentation on it here: Order of Variables

INSTALLS_ICONS is likely even not needed, as this is not a gnome application.

Address comments.

Harbormaster completed remote builds in B20908: Diff 50627.Nov 20 2018, 8:09 AM

arrowd marked 3 inline comments as done.Nov 20 2018, 8:11 AM

Looks good to me.

This revision is now accepted and ready to land.Nov 22 2018, 7:50 PM

Closed by commit rP485649: devel/tortoisehg: Update to 4.8. (authored by arrowd). · Explain WhyNov 23 2018, 10:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

devel/

tortoisehg/

4 lines

6 lines

files/

patch-tortoisehg_hgqt_qtlib.py

8 lines

3 lines

Diff 50594

devel/tortoisehg/Makefile

Loading...

devel/tortoisehg/distinfo

Loading...

devel/tortoisehg/files/patch-tortoisehg_hgqt_qtlib.py

Loading...

devel/tortoisehg/pkg-plist

Loading...