Page MenuHomeFreeBSD
Differential D2352

replace a comment about zfs recv -F corner case with a longer, more detailed one
ClosedPublic
Actions

Authored by avg on Apr 23 2015, 10:40 AM.
Tags
None
Referenced Files
F105792816: D2352.id4963.diff
Fri, Dec 20, 6:45 PM
F105776848: D2352.diff
Fri, Dec 20, 1:13 PM
Unknown Object (File)
Tue, Dec 10, 10:39 AM
Unknown Object (File)
Nov 15 2024, 8:06 AM
Unknown Object (File)
Oct 16 2024, 11:51 PM
Unknown Object (File)
Sep 28 2024, 1:34 AM
Unknown Object (File)
Sep 28 2024, 1:33 AM
Unknown Object (File)
Sep 28 2024, 1:30 AM
View All 65 Files
Subscribers
delphij
imp

Details

Reviewers
delphij
pjd
smh
Group Reviewers
ZFS
Commits
rS282131: replace a comment about zfs recv -F corner case with a longer, more detailed one
Summary

The old comment in zfs_rezget explains what situation the code handles,
the new comment also describes how the situation can arise.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avg updated this revision to Diff 4963.Apr 23 2015, 10:40 AM
avg retitled this revision from to replace a comment about zfs recv -F corner case with a longer, more detailed one.
avg updated this object.
avg edited the test plan for this revision. (Show Details)
Herald added subscribers: imp, delphij. · View Herald TranscriptApr 23 2015, 10:40 AM
avg added reviewers: smh, pjd, delphij.Apr 23 2015, 10:42 AM
avg added a reviewer: ZFS.Apr 23 2015, 10:54 AM
delphij accepted this revision.Apr 27 2015, 8:53 PM
delphij edited edge metadata.

Looks fine, please consider making the style change a separate commit though.

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c
1341 ↗(On Diff #4963)

I'd recommend this portion of change be in a different commit.

This revision is now accepted and ready to land.Apr 27 2015, 8:53 PM
smh accepted this revision.Apr 27 2015, 11:11 PM
smh edited edge metadata.

Nicely explains it to me :)

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c
1341 ↗(On Diff #4963)

Personally as they are both no-op changes I wouldn't bother splitting.

Closed by commit rS282131: replace a comment about zfs recv -F corner case with a longer, more detailed one (authored by avg). · Explain WhyApr 28 2015, 9:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
cddl/
contrib/
opensolaris/
uts/
common/
fs/
zfs/
24 lines

Diff 5052

View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c

Loading...