Page MenuHomeFreeBSD
Differential D2382

zfs ioctls: use fget_write / fget_read instead of getf wrapper for fget
ClosedPublic
Actions

Authored by avg on Apr 28 2015, 6:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 4:15 AM
Unknown Object (File)
Mon, Oct 28, 12:06 AM
Unknown Object (File)
Oct 24 2024, 6:10 PM
Unknown Object (File)
Oct 21 2024, 1:26 PM
Unknown Object (File)
Sep 30 2024, 1:54 PM
Unknown Object (File)
Sep 24 2024, 6:15 AM
Unknown Object (File)
Sep 19 2024, 4:31 PM
Unknown Object (File)
Sep 11 2024, 1:36 PM
View All 62 Files
Subscribers
delphij
imp

Details

Reviewers
delphij
mahrens
pjd
smh
Group Reviewers
manpages
Commits
rS282766: zfs ioctls: use fget_write / fget_read instead of getf wrapper for fget
Summary

This allows to ensure that we do not write a file that was opened
for reading only or vice versa.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

avg updated this revision to Diff 5046.Apr 28 2015, 6:31 AM
avg retitled this revision from to zfs ioctls: use fget_write / fget_read instead of getf wrapper for fget.
avg updated this object.
avg edited the test plan for this revision. (Show Details)
avg added reviewers: delphij, smh, pjd.
Herald added a reviewer: manpages. · View Herald TranscriptApr 28 2015, 6:31 AM
Herald added subscribers: imp, delphij. · View Herald Transcript
delphij accepted this revision.Apr 28 2015, 8:15 AM
delphij edited edge metadata.

Looks good to me.

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
5438

I think you would want to upstream a change that modifies this to fp = getf(fd); so we don't diverge here.

This revision is now accepted and ready to land.Apr 28 2015, 8:15 AM
avg added inline comments.Apr 28 2015, 9:04 AM
sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
5438

That makes sense and I would love to do it, but given how hard (for me) is to submit an upstream change it might take me a while.

avg added inline comments.Apr 28 2015, 9:06 AM
sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
5423

Please also note that the current code has a bug here: we need CAP_WRITE not CAP_READ.

smh added inline comments.Apr 28 2015, 9:40 AM
sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
5438

As matt is on the team here and illumos advocate now is this something he can assist with. I myself has also found that process very time consuming.

avg added a reviewer: mahrens.Apr 28 2015, 9:48 AM

This change is FreeBSD-specific resolution of https://www.illumos.org/issues/5872

Closed by commit rS282766: zfs ioctls: use fget_write / fget_read instead of getf wrapper for fget (authored by avg). · Explain WhyMay 11 2015, 10:07 AM
This revision was automatically updated to reflect the committed changes.
avg added a comment.May 22 2015, 8:59 AM
This comment was removed by avg.

Revision Contents
Changeset List

PathSize
sys/
cddl/
contrib/
opensolaris/
uts/
common/
fs/
zfs/
28 lines

Diff 5046

View Options

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c

Loading...