Add capsicum_helpers.h to -legacy if needed
ClosedPublic
Actions

Authored by arichardson on Nov 13 2018, 9:39 AM.

Details

Reviewers

oshogbo
emaste
bdrewery

Group Reviewers

capsicum

Commits

rS340645: Add capsicum_helpers.h to -legacy if needed

Summary

This fixed bootstrap of capsicuminzed strings.

Test Plan

Build on FreeBSD11 works again

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20778
Build 20176: arc lint + arc unit

Event Timeline

arichardson created this revision.Nov 13 2018, 9:39 AM

Herald added a subscriber: jonathan. · View Herald TranscriptNov 13 2018, 9:39 AM

Harbormaster completed remote builds in B20776: Diff 50354.Nov 13 2018, 9:39 AM

arichardson added a reviewer: capsicum.Nov 13 2018, 9:39 AM

Avoid warning message if /usr/include/capsicum_helpers.h doesn't exist

Harbormaster completed remote builds in B20777: Diff 50355.Nov 13 2018, 9:42 AM

Looks like we also need a newer version of libcasper.h in -legacy to build on 11

Harbormaster completed remote builds in B20778: Diff 50356.Nov 13 2018, 10:21 AM

The idea looks good for me, but I'm not an expert about Makefiles so I would feel bather if @bdrewery would give a look to those changes.

bdrewery accepted this revision.Nov 19 2018, 5:29 PM

This revision is now accepted and ready to land.Nov 19 2018, 5:29 PM

Closed by commit rS340645: Add capsicum_helpers.h to -legacy if needed (authored by arichardson). · Explain WhyNov 19 2018, 6:58 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 19 2018, 6:58 PM

Revision Contents
Changeset List

Path

Size

tools/

build/

Makefile

10 lines

Diff 50356

View Options

Add capsicum_helpers.h to -legacy if neededClosedPublicActions