Paths

Table of Contentst

Capsicumize brandelf.
ClosedPublic
Actions

Authored by oshogbo on Nov 12 2018, 9:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 4, 5:17 PM

	Unknown Object (File)
	Wed, Dec 4, 5:06 AM

	Unknown Object (File)
	Mon, Nov 25, 1:51 AM

	Unknown Object (File)
	Wed, Nov 20, 1:38 PM

	Unknown Object (File)
	Tue, Nov 19, 2:55 AM

	Unknown Object (File)
	Sat, Nov 16, 10:48 PM

	Unknown Object (File)
	Nov 9 2024, 2:07 PM

	Unknown Object (File)
	Nov 9 2024, 12:01 PM

View All 29 Files

Subscribers

jonathan

Details

Reviewers

cem
allanjude
emaste
markj

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

oshogbo created this revision.Nov 12 2018, 9:39 PM

Herald added a subscriber: jonathan. · View Herald TranscriptNov 12 2018, 9:39 PM

allanjude accepted this revision.Nov 12 2018, 11:36 PM

This revision is now accepted and ready to land.Nov 12 2018, 11:36 PM

markj accepted this revision.Nov 13 2018, 12:57 AM

markj added inline comments.

usr.bin/brandelf/Makefile
10	Inconsistent whitespace.
usr.bin/brandelf/brandelf.c
141	These should really have separate error messages.

emaste added inline comments.Nov 13 2018, 1:01 AM

usr.bin/brandelf/brandelf.c
141	I'm indifferent on that - is there a different action the user can take based on which error message comes out?

markj added inline comments.Nov 13 2018, 1:09 AM

usr.bin/brandelf/brandelf.c
141	No, but the first step taken by anyone debugging the error will be to figure out which of the two calls is failing.

emaste added inline comments.Nov 13 2018, 2:15 AM

usr.bin/brandelf/brandelf.c
141	Most likely the first action is to set `kern.trap_enotcap` to 1 and get a backtrace? Anyway I'm fine with either.

r340572

Revision Contents
Changeset List

Path

Size

usr.bin/

brandelf/

Makefile

8 lines

brandelf.c

25 lines

Diff 50343

View Options

usr.bin/brandelf/Makefile