Page MenuHomeFreeBSD
Differential D17941

acpica : move SRAT/SLIT parsing to sys/dev/acpica
ClosedPublic
Actions

Authored by jchandra on Nov 11 2018, 2:37 AM.
Tags
None
Referenced Files
F170213933: D17941.id.diff
Thu, Sep 3, 9:50 PM
Unknown Object (File)
Tue, Sep 1, 10:08 PM
Unknown Object (File)
Tue, Sep 1, 1:14 AM
Unknown Object (File)
Sun, Aug 30, 9:58 PM
Unknown Object (File)
Sun, Aug 30, 3:19 PM
Unknown Object (File)
Fri, Aug 28, 10:00 PM
Unknown Object (File)
Wed, Aug 26, 6:54 AM
Unknown Object (File)
Mon, Aug 24, 6:59 AM
View All Files
Subscribers
imp

Details

Reviewers
andrew
jhb
markj
imp
Group Reviewers
arm64
Commits
rS341742: acpica : move SRAT/SLIT parsing to sys/dev/acpica
Summary

This moves the architecture independent parts of sys/x86/acpica/srat.c to sys/dev/acpica/acpi_pxm.c, to be used later on arm64. The function declarations are moved to sys/dev/acpica/acpivar.h

We also need to update sys/conf/files.{i386,amd64} to use the new file. No functional changes.

Test Plan

No effect on x86 (numa/non-numa)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 20747

Event Timeline

jchandra created this revision.Nov 11 2018, 2:37 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 11 2018, 2:37 AM
Harbormaster completed remote builds in B20747: Diff 50276.Nov 11 2018, 2:37 AM
andrew added a reviewer: markj.Nov 13 2018, 10:38 AM
markj added inline comments.Nov 15 2018, 10:22 PM
sys/x86/acpica/srat.c
51

Are all of these includes still needed?

jchandra planned changes to this revision.Nov 16 2018, 1:58 AM
jchandra marked an inline comment as done.

Thanks for the review - will post new version dropping a few includes.

sys/x86/acpica/srat.c
51

I can drop a few includes.

jchandra updated this revision to Diff 50578.Nov 19 2018, 1:40 AM

Addressed markj's comment - removed unnecessary includes.

Harbormaster completed remote builds in B20883: Diff 50578.Nov 19 2018, 1:40 AM
markj accepted this revision.Dec 3 2018, 2:51 PM
This revision is now accepted and ready to land.Dec 3 2018, 2:51 PM
imp accepted this revision.Dec 3 2018, 3:26 PM
Closed by commit rS341742: acpica : move SRAT/SLIT parsing to sys/dev/acpica (authored by jchandra). · Explain WhyDec 8 2018, 7:11 PM
This revision was automatically updated to reflect the committed changes.
jchandra mentioned this in rS352496: MFC r341741-r341742.Sep 18 2019, 10:45 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
1 line
dev/
acpica/
654 lines
9 lines
x86/
acpica/
611 lines

Diff 50276

View Options

sys/conf/files.amd64

Loading...
View Options

sys/conf/files.i386

Loading...
View Options

sys/dev/acpica/acpi_pxm.c

Loading...
View Options

sys/dev/acpica/acpivar.h

Loading...
View Options

sys/x86/acpica/srat.c

Loading...