Differential D17849

Add a KPI for the delay while spinning on a spin lock.
ClosedPublic
Actions

Authored by jhb on Nov 5 2018, 6:11 PM.

Tags

None

Referenced Files

	F167259750: D17849.diff
	Thu, Aug 20, 11:16 AM

	F167242565: D17849.diff
	Thu, Aug 20, 7:13 AM

	Unknown Object (File)
	Wed, Aug 19, 1:24 PM

	Unknown Object (File)
	Tue, Aug 18, 7:32 PM

	Unknown Object (File)
	Wed, Aug 12, 11:28 AM

	Unknown Object (File)
	Jul 11 2026, 4:10 PM

	Unknown Object (File)
	Jun 4 2026, 6:42 PM

	Unknown Object (File)
	May 25 2026, 9:17 PM

View All 85 Files

Subscribers

Details

Reviewers

kib
manu

Commits

rS340164: Add a KPI for the delay while spinning on a spin lock.

Summary

Replace a call to DELAY(1) with a new cpu_lock_delay() KPI. Currently
cpu_lock_delay() is defined to DELAY(1) on all platforms. However,
platforms with a DELAY() implementation that uses spin locks should
implement a custom cpu_lock_delay() doesn't use locks.

Test Plan

passed make tinderbox (aside from unrelated breakage in arm.GENERIC-NODEBUG)
booted in i386 and amd64 VMs
original PR reporter booted combined patch on amd64 machine

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 20640
Build 20056: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 5 2018, 6:11 PM

Herald added a reviewer: manu. · View Herald TranscriptNov 5 2018, 6:11 PM

Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B20640: Diff 50032.Nov 5 2018, 6:11 PM

jhb added a child revision: D17850: Add a delay_tsc() static function for when DELAY() uses the TSC..Nov 5 2018, 6:14 PM

kib accepted this revision.Nov 5 2018, 9:22 PM

This revision is now accepted and ready to land.Nov 5 2018, 9:22 PM

jhb closed this revision.Nov 5 2018, 10:47 PM

jhb added a commit: rS340164: Add a KPI for the delay while spinning on a spin lock..

Revision Contents
Changeset List

Path

Size

sys/

amd64/

include/

1 line

arm/

include/

1 line

arm64/

include/

1 line

i386/

include/

1 line

kern/

2 lines

mips/

include/

1 line

powerpc/

include/

1 line

riscv/

include/

1 line

sparc64/

include/

1 line

Diff 50032

sys/amd64/include/cpu.h

Loading...

sys/arm/include/cpu.h

Loading...

sys/arm64/include/cpu.h

Loading...

sys/i386/include/cpu.h

Loading...

sys/kern/kern_mutex.c

Loading...

sys/mips/include/cpu.h

Loading...

sys/powerpc/include/cpu.h

Loading...

sys/riscv/include/cpu.h

Loading...

sys/sparc64/include/cpu.h

Loading...