Cosmetic changes to try to inline the memset with SSE/AVX instructions.
ClosedPublic
Actions

Authored by araujo on Nov 1 2018, 8:06 AM.

Details

Reviewers

rgrimes
jhb
brooks

Group Reviewers

bhyve

Commits

rS341761: MFC r340211:
rS340211: Comestic change to try to inline the memset with SSE/AVX instructions.

Summary

This topic was discussed on review D17759.

Test Plan

Linux Guest with disk nvme ram.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20592
Build 20013: arc lint + arc unit

Event Timeline

araujo created this revision.Nov 1 2018, 8:06 AM

Herald added a reviewer: rgrimes. · View Herald TranscriptNov 1 2018, 8:06 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B20561: Diff 49865.Nov 1 2018, 8:07 AM

araujo added reviewers: jhb, bhyve.Nov 1 2018, 8:07 AM

brooks added a subscriber: brooks.Nov 1 2018, 5:30 PM

brooks added inline comments.

usr.sbin/bhyve/pci_nvme.c
258–259	@jhb's suggestion was that this should become: memset(dst, pad, dist_size);

Address the memset according with the suggestion made by @jhb.

Harbormaster completed remote builds in B20592: Diff 49920.Nov 2 2018, 2:01 AM

araujo added a reviewer: brooks.Nov 2 2018, 2:02 AM

araujo marked an inline comment as done.

araujo added inline comments.

usr.sbin/bhyve/pci_nvme.c
258–259	Yes, thank you! I read that wrong, sorry about the noise.

ping!

Commit message should mention the switch to size_t.

usr.sbin/bhyve/pci_nvme.c
256	Style(9) would have you do put a blank line after decelerations and do the assignment on a separate line.

This revision is now accepted and ready to land.Nov 5 2018, 5:32 PM

Closed by commit rS340211: Comestic change to try to inline the memset with SSE/AVX instructions. (authored by araujo). · Explain WhyNov 7 2018, 6:29 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_nvme.c

6 lines

Diff 49920

View Options

Cosmetic changes to try to inline the memset with SSE/AVX instructions.ClosedPublicActions