Use mode_t when the documented signature does.
ClosedPublic
Actions

Authored by brooks on Oct 31 2018, 8:47 PM.

Details

Reviewers

kib
jhb
emaste

Commits

rS340035: Regent after r340034: Use mode_t when the documented signature does.
rS340034: Use mode_t when the documented signature does.

Summary

This is more clear and produces better results when generating function
stubs from syscalls.master.

Obtained from: CheriBSD
Sponsored by: DARPA, AFRL

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20543
Build 19968: arc lint + arc unit

Event Timeline

brooks created this revision.Oct 31 2018, 8:47 PM

Harbormaster completed remote builds in B20543: Diff 49843.Oct 31 2018, 8:47 PM

I think this change is good.
__mode_t is uint16_t, this is OK on all of our architectures?

In D17784#380088, @emaste wrote:

I think this change is good.
__mode_t is uint16_t, this is OK on all of our architectures?

Should be. i386 passes args as 32-bit words on the stack and the rest pass in registers. They are passed as mode_t by the caller already.

What about compat32 ?

This revision is now accepted and ready to land.Oct 31 2018, 11:50 PM

emaste accepted this revision.Nov 1 2018, 12:12 AM

Add compat32.

This revision now requires review to proceed.Nov 1 2018, 5:51 PM

Harbormaster completed remote builds in B20580: Diff 49894.Nov 1 2018, 5:51 PM

emaste accepted this revision.Nov 1 2018, 7:36 PM

This revision is now accepted and ready to land.Nov 1 2018, 7:36 PM

kib accepted this revision.Nov 1 2018, 10:17 PM

Closed by commit rS340034: Use mode_t when the documented signature does. (authored by brooks). · Explain WhyNov 1 2018, 11:06 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2018, 11:06 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

syscalls.master

12 lines

Diff 49843

View Options

Use mode_t when the documented signature does.ClosedPublicActions