Page MenuHomeFreeBSD
Differential D17784

Use mode_t when the documented signature does.
ClosedPublic
Actions

Authored by brooks on Oct 31 2018, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 14, 9:09 AM
Unknown Object (File)
Thu, Aug 13, 6:38 PM
Unknown Object (File)
Thu, Aug 13, 6:37 PM
Unknown Object (File)
Mon, Aug 10, 4:54 PM
Unknown Object (File)
Mon, Aug 10, 10:18 AM
Unknown Object (File)
Sun, Aug 9, 3:15 AM
Unknown Object (File)
Fri, Aug 7, 4:45 PM
Unknown Object (File)
Fri, Aug 7, 8:52 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
jhb
emaste
Commits
rS340035: Regent after r340034: Use mode_t when the documented signature does.
rS340034: Use mode_t when the documented signature does.
Summary

This is more clear and produces better results when generating function
stubs from syscalls.master.

Obtained from: CheriBSD
Sponsored by: DARPA, AFRL

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Oct 31 2018, 8:47 PM
Harbormaster completed remote builds in B20543: Diff 49843.Oct 31 2018, 8:47 PM
emaste added a comment.Oct 31 2018, 9:00 PM

I think this change is good.
__mode_t is uint16_t, this is OK on all of our architectures?

brooks added a comment.Oct 31 2018, 9:53 PM
In D17784#380088, @emaste wrote:

I think this change is good.
__mode_t is uint16_t, this is OK on all of our architectures?

Should be. i386 passes args as 32-bit words on the stack and the rest pass in registers. They are passed as mode_t by the caller already.

kib accepted this revision.Oct 31 2018, 11:50 PM

What about compat32 ?

This revision is now accepted and ready to land.Oct 31 2018, 11:50 PM
emaste accepted this revision.Nov 1 2018, 12:12 AM
brooks updated this revision to Diff 49894.Nov 1 2018, 5:51 PM
  • Add compat32.
This revision now requires review to proceed.Nov 1 2018, 5:51 PM
Harbormaster completed remote builds in B20580: Diff 49894.Nov 1 2018, 5:51 PM
emaste accepted this revision.Nov 1 2018, 7:36 PM
This revision is now accepted and ready to land.Nov 1 2018, 7:36 PM
kib accepted this revision.Nov 1 2018, 10:17 PM
Closed by commit rS340034: Use mode_t when the documented signature does. (authored by brooks). · Explain WhyNov 1 2018, 11:06 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 1 2018, 11:06 PM

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
freebsd32/
12 lines
kern/
12 lines

Diff 49913

View Options

head/sys/compat/freebsd32/syscalls.master

Loading...
View Options

head/sys/kern/syscalls.master

Loading...