pw: file == NULL check in read_userconfig() is always false
ClosedPublic
Actions

Authored by yuripv on Oct 15 2018, 8:45 PM.

Details

Reviewers

bapt
eugen_grosbein.net

Commits

rS339380: pw: (file == NULL) check is always false in read_userconfig(), remove

Summary

Submitted by Gleb.

read_userconfig() is called from get_userconfig() with non-NULL argument, so the check is always false. Drop the _PATH_PW_CONF definition as well.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuripv created this revision.Oct 15 2018, 8:45 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 15 2018, 8:45 PM

Looks good. While you are here, please also replace last "/etc" literal in the pw.c's main() function with _PATH_PWD used with all other places of pw(1) sources.

Suggestion from Eugene.

In D17575#375226, @eugen_grosbein.net wrote:

Looks good. While you are here, please also replace last "/etc" literal in the pw.c's main() function with _PATH_PWD used with all other places of pw(1) sources.

Makes sense.

eugen_grosbein.net accepted this revision.Oct 16 2018, 11:04 AM

This revision is now accepted and ready to land.Oct 16 2018, 11:04 AM

Closed by commit rS339380: pw: (file == NULL) check is always false in read_userconfig(), remove (authored by yuripv). · Explain WhyOct 16 2018, 4:00 PM

This revision was automatically updated to reflect the committed changes.