net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver
AbandonedPublic
Actions

Authored by skozlov on Oct 5 2018, 8:53 PM.

Details

Reviewers

sbruno
koobs

Commits

rP481900: 0~net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver

Summary

New port for updated 10g Intel Ethernet Base Driver, based on
net/intel-ixl-kmod as a master port.

Depends on D17440, must be committed after it.

Test Plan

Compile and sanity tested using poudriere w/portlint:

intel-ix-kmod-3.3.6.log102 KBDownload

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 20144
Build 19638: arc lint + arc unit

Event Timeline

skozlov created this revision.Oct 5 2018, 8:53 PM

Herald added a subscriber: mat. · View Herald TranscriptOct 5 2018, 8:53 PM

Harbormaster completed remote builds in B20018: Diff 48813.Oct 5 2018, 8:53 PM

skozlov edited the test plan for this revision. (Show Details)Oct 5 2018, 8:55 PM

skozlov added a project: Intel Networking.

Does this require a LICENSE or some sort?

This revision now requires changes to proceed.Oct 5 2018, 9:22 PM

In D17443#372074, @sbruno wrote:

Does this require a LICENSE or some sort?

License is BSD2CLAUSE and is set in the master port

Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:

MANPAGENAME=        ixgbe
MANPAGELINKS=        ix if_ix if_ixgbe
MAX_NETMAP_OSVERSION=        1199999  # Doesn't build w/NETMAP on 12

net/intel-ix-kmod/Makefile
11	The build uses -Werror which is great for upstream, but not good for distribution (the distributed source). Please add `CFLAGS+=-Wno-error`

erj added a subscriber: erj.Oct 8 2018, 8:28 PM

erj added inline comments.

net/intel-ix-kmod/pkg-descr
5	Shouldn't this be expanded to X520/X540/X550 series, too? Or just 500 series adapters, in general?

In D17443#372344, @koobs wrote:
Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:
MANPAGENAME=        ixgbe
MANPAGELINKS=        ix if_ix if_ixgbe
MAX_NETMAP_OSVERSION=        1199999  # Doesn't build w/NETMAP on 12

Will do. Do you have any specific warnings showing up for you?

In D17443#372892, @skozlov wrote:
In D17443#372344, @koobs wrote:
Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:
MANPAGENAME=        ixgbe
MANPAGELINKS=        ix if_ix if_ixgbe
MAX_NETMAP_OSVERSION=        1199999  # Doesn't build w/NETMAP on 12
Will do. Do you have any specific warnings showing up for you?

None on CURRENT/amd64

Add X5* controllers to supported list

Harbormaster completed remote builds in B20144: Diff 49026.Oct 11 2018, 5:19 PM

I'll add -Wno-error to the master port, but because of the amount of testing it will require - I'd like to make it a separate review.

skozlov marked an inline comment as done.Oct 11 2018, 5:20 PM

sbruno accepted this revision.Oct 11 2018, 5:40 PM

skozlov added a commit: rP481900: 0~net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver.Oct 12 2018, 1:22 PM

net/intel-{ix,em}-kmod: freeze PORTREVISION and PORTEPOCH

PORTREVISION wasn't specified in net/intel-{ix,em}-kmod, which are
slave ports of net/intel-ixl-kmod. Because of that when PORTREVISION
was bumped in intel-ixl-kmod - it automatically appeared in the slave
ports, which shouldn't happen.

To avoid this in the future - explicitly specify PORTREVISION and
PORTEPOCH in the slave ports.

Harbormaster completed remote builds in B20329: Diff 49435.Oct 22 2018, 11:23 AM

Original patch committed in r481900
The revision wasn't automatically closed because I wasn't able to use the arcanist properly :(