Page MenuHomeFreeBSD

net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver
AbandonedPublic

Authored by skozlov on Oct 5 2018, 8:53 PM.
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:38 PM
Unknown Object (File)
Fri, Dec 20, 5:35 PM
Unknown Object (File)
Fri, Dec 20, 12:10 PM
Unknown Object (File)
Wed, Dec 4, 12:56 PM
Unknown Object (File)
Wed, Dec 4, 12:55 PM
Unknown Object (File)
Wed, Dec 4, 12:55 PM
Unknown Object (File)
Wed, Dec 4, 12:55 PM
Unknown Object (File)
Wed, Dec 4, 12:36 PM
Subscribers

Details

Summary

New port for updated 10g Intel Ethernet Base Driver, based on
net/intel-ixl-kmod as a master port.

Depends on D17440, must be committed after it.

Test Plan

Compile and sanity tested using poudriere w/portlint:

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20329
Build 19782: arc lint + arc unit

Event Timeline

skozlov added a project: Intel Networking.
sbruno requested changes to this revision.Oct 5 2018, 9:22 PM

Does this require a LICENSE or some sort?

This revision now requires changes to proceed.Oct 5 2018, 9:22 PM

Does this require a LICENSE or some sort?

License is BSD2CLAUSE and is set in the master port

koobs requested changes to this revision.Oct 7 2018, 10:09 AM

Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:

MANPAGENAME=        ixgbe
MANPAGELINKS=        ix if_ix if_ixgbe
​MAX_NETMAP_OSVERSION=        1199999  # Doesn't build w/NETMAP on 12
net/intel-ix-kmod/Makefile
10

The build uses -Werror which is great for upstream, but not good for distribution (the distributed source).

Please add CFLAGS+=-Wno-error

erj added inline comments.
net/intel-ix-kmod/pkg-descr
4 ↗(On Diff #48813)

Shouldn't this be expanded to X520/X540/X550 series, too? Or just 500 series adapters, in general?

Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:

MANPAGENAME=        ixgbe
MANPAGELINKS=        ix if_ix if_ixgbe
​MAX_NETMAP_OSVERSION=        1199999  # Doesn't build w/NETMAP on 12

Will do. Do you have any specific warnings showing up for you?

Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:

MANPAGENAME=        ixgbe
MANPAGELINKS=        ix if_ix if_ixgbe
​MAX_NETMAP_OSVERSION=        1199999  # Doesn't build w/NETMAP on 12

Will do. Do you have any specific warnings showing up for you?

None on CURRENT/amd64

Add X5* controllers to supported list

I'll add -Wno-error to the master port, but because of the amount of testing it will require - I'd like to make it a separate review.

net/intel-{ix,em}-kmod: freeze PORTREVISION and PORTEPOCH

PORTREVISION wasn't specified in net/intel-{ix,em}-kmod, which are
slave ports of net/intel-ixl-kmod. Because of that when PORTREVISION
was bumped in intel-ixl-kmod - it automatically appeared in the slave
ports, which shouldn't happen.

To avoid this in the future - explicitly specify PORTREVISION and
PORTEPOCH in the slave ports.

Original patch committed in r481900
The revision wasn't automatically closed because I wasn't able to use the arcanist properly :(