Provide string functions for use before ifuncs get resolved.
ClosedPublic
Actions

Authored by mjg on Oct 9 2018, 9:20 PM.

Details

Reviewers

kib
royger

Commits

rS339321: Provide string functions for use before ifuncs get resolved.

Summary

The change is a no-op for architectures which don't ifunc memset, memcpy nor memmove.

Test Plan

tinderbox, royger's use case

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mjg created this revision.Oct 9 2018, 9:20 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 9 2018, 9:20 PM

Harbormaster completed remote builds in B20099: Diff 48950.Oct 9 2018, 9:20 PM

Thanks, this allows to fix the Xen boot issue. Would you mind including the following diff into your patch?

http://xenbits.xen.org/people/royger/fix_early_memset.patch

I think it's much better if the patch also fixes the current usages, or else you are introducing a set of functions that are unused.

This revision is now accepted and ready to land.Oct 10 2018, 7:31 AM

In D17487#373303, @royger wrote:

Thanks, this allows to fix the Xen boot issue. Would you mind including the following diff into your patch?

http://xenbits.xen.org/people/royger/fix_early_memset.patch

I think it's much better if the patch also fixes the current usages, or else you are introducing a set of functions that are unused.

There is also the use in link_elf.c:link_elf_ireloc().