Page MenuHomeFreeBSD

Provide string functions for use before ifuncs get resolved.
ClosedPublic

Authored by mjg on Oct 9 2018, 9:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 4:08 PM
Unknown Object (File)
Sat, Nov 16, 6:30 AM
Unknown Object (File)
Oct 3 2024, 7:06 PM
Unknown Object (File)
Oct 1 2024, 6:18 PM
Unknown Object (File)
Oct 1 2024, 5:32 PM
Unknown Object (File)
Sep 29 2024, 3:54 PM
Unknown Object (File)
Sep 29 2024, 7:18 AM
Unknown Object (File)
Sep 28 2024, 9:53 PM
Subscribers

Details

Summary

The change is a no-op for architectures which don't ifunc memset, memcpy nor memmove.

Test Plan

tinderbox, royger's use case

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks, this allows to fix the Xen boot issue. Would you mind including the following diff into your patch?

http://xenbits.xen.org/people/royger/fix_early_memset.patch

I think it's much better if the patch also fixes the current usages, or else you are introducing a set of functions that are unused.

This revision is now accepted and ready to land.Oct 10 2018, 7:31 AM

Thanks, this allows to fix the Xen boot issue. Would you mind including the following diff into your patch?

http://xenbits.xen.org/people/royger/fix_early_memset.patch

I think it's much better if the patch also fixes the current usages, or else you are introducing a set of functions that are unused.

There is also the use in link_elf.c:link_elf_ireloc().

sys/amd64/include/cpufunc.h
1019 ↗(On Diff #48950)

cpufunc.h is definitely wrong place. I suggested cpu.h.

  • move macros to cpu.h
  • convert current hand-rolled code to use early, xen bits from royger
This revision now requires review to proceed.Oct 11 2018, 2:30 PM

Is there any way to know you've got them all?

This revision is now accepted and ready to land.Oct 11 2018, 4:20 PM
This revision was automatically updated to reflect the committed changes.