Page MenuHomeFreeBSD
Differential D17473

fix PNP entries for if_ix and if_ixv
ClosedPublic
Actions

Authored by yuripv on Oct 8 2018, 4:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 9:12 AM
Unknown Object (File)
Mon, May 13, 8:00 AM
Unknown Object (File)
Sun, May 12, 10:07 AM
Unknown Object (File)
Sat, Apr 27, 3:20 PM
Unknown Object (File)
Apr 12 2024, 6:07 AM
Unknown Object (File)
Apr 10 2024, 4:55 AM
Unknown Object (File)
Mar 7 2024, 4:33 PM
Unknown Object (File)
Jan 7 2024, 7:45 AM
View All 22 Files
Subscribers
ae
erj

Details

Reviewers
imp
sbruno
Commits
rS339319: Fix PNP entries for if_ix and if_ixv properly using the IFLIB_PNP_INFO()
Summary

While looking at devmatch -d output, I noticed that entries for if_ix and if_ixv are bogus (lots of "0x8086:0:").

Fix this using the proper IFLIB_PNP_INFO macro.

Test Plan

devmatch -d

Module ix_pci in if_ix.ko
PNP info for bus pci format I:vendor;I:device;I:subvendor;I:subdevice;I:revision;I:class;D:#; 44 entries (if_ix.ko)
   0x8086:0x10c6:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10c7:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10dd:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10c8:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x150b:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10b6:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10f1:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10ec:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10f4:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10e1:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10db:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10f7:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1514:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10fb:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10fc:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10f9:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x151c:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10f8:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x152a:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x154d:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1529:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1557:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x154a:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1558:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1528:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1560:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1563:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15d1:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15ab:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15aa:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15ad:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15ae:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15ac:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c2:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c3:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15ce:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c4:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c6:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c7:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c8:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15e4:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15e5:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x155c:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x155d:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
Module ixv_pci in if_ixv.ko
PNP info for bus pci format I:vendor;I:device;I:subvendor;I:subdevice;I:revision;I:class;D:#; 5 entries (if_ixv.ko)
   0x8086:0x10ed:0:0:0:0:'Intel(R) PRO/10GbE Virtual Function Network Driver':
   0x8086:0x1515:0:0:0:0:'Intel(R) PRO/10GbE Virtual Function Network Driver':
   0x8086:0x1565:0:0:0:0:'Intel(R) PRO/10GbE Virtual Function Network Driver':
   0x8086:0x15a8:0:0:0:0:'Intel(R) PRO/10GbE Virtual Function Network Driver':
   0x8086:0x15c5:0:0:0:0:'Intel(R) PRO/10GbE Virtual Function Network Driver':

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

yuripv created this revision.Oct 8 2018, 4:02 PM
Herald added a reviewer: sbruno. · View Herald TranscriptOct 8 2018, 4:02 PM
Herald added a subscriber: ae. · View Herald Transcript
erj added a subscriber: erj.Oct 8 2018, 4:42 PM

I can't tell if this is right or not, but it looks like an ok change to me.

yuripv edited the test plan for this revision. (Show Details)Oct 8 2018, 4:44 PM

Sorry, I forgot to add the output from devmatch -d for fixed versions. Done now.

imp accepted this revision.Oct 8 2018, 5:28 PM

Seems reasonable to me. The old description looks to not be quite right and this fixes it.

This revision is now accepted and ready to land.Oct 8 2018, 5:28 PM
sbruno accepted this revision.Oct 11 2018, 5:50 PM
sbruno added a comment.Oct 11 2018, 5:58 PM

@yuripv Do you want me to commit this or are you going to be able to send the request to release engineering?

https://wiki.freebsd.org/Releng/ChangeRequestGuidelines

yuripv added a comment.Oct 11 2018, 6:00 PM
In D17473#373892, @sbruno wrote:

@yuripv Do you want me to commit this or are you going to be able to send the request to release engineering?

https://wiki.freebsd.org/Releng/ChangeRequestGuidelines

I can do this now, yes.

Closed by commit rS339319: Fix PNP entries for if_ix and if_ixv properly using the IFLIB_PNP_INFO() (authored by yuripv). · Explain WhyOct 11 2018, 10:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
ixgbe/
4 lines
3 lines

Diff 48897

View Options

sys/dev/ixgbe/if_ix.c

Loading...
View Options

sys/dev/ixgbe/if_ixv.c

Loading...