Page MenuHomeFreeBSD

PR225692: localedef: mark "space" also as "print" excluding known conflicts
ClosedPublic

Authored by yuripv on Oct 8 2018, 11:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 11 2024, 9:52 PM
Unknown Object (File)
Dec 22 2023, 11:03 PM
Unknown Object (File)
Dec 3 2023, 8:24 AM
Unknown Object (File)
Aug 21 2023, 9:29 AM
Unknown Object (File)
Jul 15 2023, 7:55 PM
Unknown Object (File)
May 14 2023, 6:38 AM
Unknown Object (File)
May 7 2023, 10:00 AM
Unknown Object (File)
Apr 25 2023, 6:36 PM
Subscribers

Details

Summary

PR: 225692

The POSIX locale definition says the following:

print

Define characters to be classified as printable characters, including the <space>.

In the POSIX locale, all characters in class graph shall be included; no characters in class cntrl shall be included.

In a locale definition file, characters specified for the keywords upper, lower, alpha, digit, xdigit, punct, graph, and the <space> are automatically included in this class. No character specified for the keyword cntrl shall be specified.

So it doesn't explicitly say anything about "space" here, though it doesn't NOT explicitly forbid including "space" in the "print" class, and I *think* we can extend the <space> character being included to the entire "space" character class.

Test Plan

Build/install in share/ctypedefs, run the test case attached to PR225692.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

LGTM.
(I currently don't have the time to go over to Release Engineering for this though ::-/ )

This revision is now accepted and ready to land.Oct 8 2018, 3:00 PM

No objection from me, although I am not very familiar with this particular code or POSIX in this area.

Ditto pfg—I don't have time to do re's process to commit this to head while it is frozen.

rebase on top of recent localedef changes; make the change less intrusive keeping the warning and only stripping "print" from "space|control" combination.

This revision now requires review to proceed.Oct 21 2018, 1:00 PM
This revision is now accepted and ready to land.Oct 23 2018, 2:45 PM
This revision was automatically updated to reflect the committed changes.