The only potential issue I see is that the igb devices create
an offload context for VLANs and don't set offset to false and
unconditionally request IP level offloads. While it's not setting
E1000_ADVTXD_TUCMD_L4T_UDP, this may still be causing the issue.
Details
Details
- Reviewers
lev erj sbruno vangyzen - Commits
- rS339207: Fix igb corrupting checksums with BPF and VLAN
Get lev to test it
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19938 Build 19455: arc lint + arc unit
Event Timeline
Comment Actions
This patch (first version) breaks my I210 completely. With it physical interface without any VLANs could not mount NFS share, for example. Something simple, like "ping" works, but all complex protocols are broken.
I didn't check VLANs, because host without NFS shares and other such protocols renders itself useless.
Comment Actions
Explicitly set E1000_TXD_POPTS_TXSM when setting the checksum type.
Looks like IP offloads are handled in the TSO setup, and the check here
is just to set the appropriate IP version flag.
Comment Actions
Second version works, both without VLAN_HWTAGGING and with it, physical network and VLANs.
Comment Actions
"Abandoning" because I put the wrong URL in the commit message.
rS339207: Fix igb corrupting checksums with BPF and VLAN