Page MenuHomeFreeBSD
Differential D17247

Move kernel vmem arena initialization to vm_kern.c.
ClosedPublic
Actions

Authored by markj on Sep 19 2018, 5:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 21, 7:00 AM
Unknown Object (File)
Mon, Sep 21, 7:00 AM
Unknown Object (File)
Mon, Sep 21, 6:57 AM
Unknown Object (File)
Fri, Sep 18, 10:03 PM
Unknown Object (File)
Fri, Sep 18, 3:02 AM
Unknown Object (File)
Tue, Sep 8, 9:19 AM
Unknown Object (File)
Tue, Sep 1, 12:22 PM
Unknown Object (File)
Aug 22 2026, 8:42 AM
View All Files
Subscribers
imp

Details

Reviewers
alc
jeff
kib
Commits
rS338806: Move kernel vmem arena initialization to vm_kern.c.
Summary

The details of this initialization belong in vm_kern.c anyway, and allow
me to use KVA_QUANTUM in vm_kern.c without defining it in a header.

No functional change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Sep 19 2018, 5:20 PM
Harbormaster completed remote builds in B19680: Diff 48229.Sep 19 2018, 5:20 PM
markj added reviewers: alc, jeff, kib.Sep 19 2018, 5:21 PM
markj mentioned this in D17175: Fix memguard when options NUMA is configured..
alc accepted this revision.Sep 19 2018, 5:54 PM
alc added inline comments.
sys/vm/vm_kern.c
745–747 ↗(On Diff #48229)

It's not clear to me that using vmem_alloc() as the import function guarantees alignment. I fear that we are only guaranteed that the size is a multiple of KVA_QUANTUM.

This revision is now accepted and ready to land.Sep 19 2018, 5:54 PM
markj marked 2 inline comments as done.Sep 19 2018, 6:28 PM
markj added inline comments.
sys/vm/vm_kern.c
745–747 ↗(On Diff #48229)

I think you're right, and the problem is only hidden as a result of the current kernel arena usage patterns. In particular, vmem freelist entries aren't necessarily size-aligned.

Closed by commit rS338806: Move kernel vmem arena initialization to vm_kern.c. (authored by markj). · Explain WhySep 19 2018, 7:13 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptSep 19 2018, 7:13 PM

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
84 lines
82 lines

Diff 48235

View Options

head/sys/vm/vm_init.c

Loading...
View Options

head/sys/vm/vm_kern.c

Loading...