The details of this initialization belong in vm_kern.c anyway, and allow
me to use KVA_QUANTUM in vm_kern.c without defining it in a header.
No functional change intended.
Details
Details
- Reviewers
alc jeff kib - Commits
- rS338806: Move kernel vmem arena initialization to vm_kern.c.
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19680 Build 19247: arc lint + arc unit
Event Timeline
| sys/vm/vm_kern.c | ||
|---|---|---|
| 745–747 | It's not clear to me that using vmem_alloc() as the import function guarantees alignment. I fear that we are only guaranteed that the size is a multiple of KVA_QUANTUM. | |
| sys/vm/vm_kern.c | ||
|---|---|---|
| 745–747 | I think you're right, and the problem is only hidden as a result of the current kernel arena usage patterns. In particular, vmem freelist entries aren't necessarily size-aligned. | |