Page MenuHomeFreeBSD
Differential D17228

editors/teco: provide detailed manual page and set maintainership
ClosedPublic
Actions

Authored by fernape on Sep 18 2018, 8:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 19 2025, 1:03 AM
Unknown Object (File)
Dec 15 2024, 6:45 AM
Unknown Object (File)
Dec 5 2024, 6:35 AM
Unknown Object (File)
Dec 4 2024, 10:09 AM
Unknown Object (File)
Nov 30 2024, 2:34 AM
Unknown Object (File)
Nov 27 2024, 1:00 PM
Unknown Object (File)
Nov 21 2024, 1:06 PM
Unknown Object (File)
Nov 21 2024, 7:31 AM
View All 67 Files
Subscribers
mat

Details

Reviewers
tcberner
tz
Commits
rP480869: editors/teco: Improve documentation and set maintainership
Summary

Via PR 231184

  • Set new maintainer
  • Add man page
  • Add LICENSE
Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • run test on 11.2 amd64 OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19675
Build 19242: arc lint + arc unit

Event Timeline

fernape created this revision.Sep 18 2018, 8:34 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 18 2018, 8:34 PM
Harbormaster completed remote builds in B19653: Diff 48186.Sep 18 2018, 8:34 PM
mat added inline comments.Sep 18 2018, 9:10 PM
editors/teco/files/README.bsd.in
31–35

As this file is only present if the DOCS option is on, and it is in DOCSDIR, I'm unsure what this paragraph adds exactly.

editors/teco/pkg-message
9

Mmmm, 'read the man page' does not seem to be a very interesting pkg-message, maybe it should be removed. (Or README.bsd should be put in there.)

fernape updated this revision to Diff 48222.Sep 19 2018, 4:09 PM

Moving note about installed documentation from README.bsd.in to pkg-message

Harbormaster completed remote builds in B19675: Diff 48222.Sep 19 2018, 4:09 PM
fernape marked 2 inline comments as done.Sep 19 2018, 4:10 PM
fernape added inline comments.
editors/teco/pkg-message
9

I added the piece from README.bsd.in

fernape marked an inline comment as done.Sep 19 2018, 4:14 PM

Does this look good?

mat added a comment.Sep 21 2018, 8:04 AM

I don't really get why there is a new file README.bsd.in at all, pkg-message is the right place to put that information.

editors/teco/Makefile
16

This was probably at the right place before.

17–18

This is not a standard framework variable, should happen later.

fernape updated this revision to Diff 48318.Sep 21 2018, 4:03 PM
  • Relocating OPTIONS_DEFINE and DOCSFILES
  • Removing README file and adding its contents to pkg-message
Harbormaster completed remote builds in B19730: Diff 48318.Sep 21 2018, 4:03 PM
fernape marked 2 inline comments as done.Sep 21 2018, 4:04 PM
fernape mentioned this in D17072: editors/teco: Improved documentation.Sep 23 2018, 5:32 PM
fernape added a comment.Sep 27 2018, 4:09 PM

Does this look good now?

tcberner accepted this revision.Sep 28 2018, 5:17 AM

Looks fine :)

This revision is now accepted and ready to land.Sep 28 2018, 5:17 AM
Closed by commit rP480869: editors/teco: Improve documentation and set maintainership (authored by fernape). · Explain WhySep 28 2018, 5:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
editors/
teco/
18 lines
files/
32 lines
26 lines
92 lines
32 lines
506 lines
8 lines
18 lines
2 lines

Diff 48222

View Options

editors/teco/Makefile

Loading...
View Options

editors/teco/files/README.bsd.in

Loading...
View Options

editors/teco/files/patch-makefile

Loading...
View Options

editors/teco/files/patch-src_makefile

Loading...
View Options

editors/teco/files/patch-src_skpcmd.c

Loading...
View Options

editors/teco/files/patch-src_zlinux.c

Loading...
View Options

editors/teco/files/patch-zlinux

Loading...
View Options

editors/teco/files/teco.1.in

Loading...
View Options

editors/teco/pkg-descr

Loading...
View Options

editors/teco/pkg-message

Loading...
View Options

editors/teco/pkg-plist

Loading...