Page MenuHomeFreeBSD

editors/teco: Improved documentation
AbandonedPublic

Authored by fernape on Sep 7 2018, 5:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 10:01 AM
Unknown Object (File)
Mar 30 2024, 11:01 AM
Unknown Object (File)
Dec 21 2023, 3:46 PM
Unknown Object (File)
Dec 20 2023, 1:07 AM
Unknown Object (File)
Nov 25 2023, 8:10 PM
Unknown Object (File)
Nov 11 2023, 2:44 AM
Unknown Object (File)
Nov 8 2023, 5:13 AM
Unknown Object (File)
Nov 6 2023, 11:01 PM
Subscribers

Details

Reviewers
tcberner
tz
Summary

Via 231184

Submitter claims ownership.

  • Added manual page.
  • Recreated patched to conform to style
  • Maintainership change
Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • Runs ok in 11.2 amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19463
Build 19056: arc lint + arc unit

Event Timeline

fernape retitled this revision from editors/teco: Improved documentation Via [[ https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231184 | 231184 ]] Submitter claims ownership. to editors/teco: Improved documentation.Sep 7 2018, 5:19 PM
fernape edited the summary of this revision. (Show Details)
editors/teco/Makefile
5–6

Don't change that unless the version actually changes.

editors/teco/Makefile
5–6

This update changes the plist and adds man page and README, something some people would welcome. Doesn't that justify the bump in PORTREVISION?

editors/teco/Makefile
5–6

Wait, do you mean DISTVERSION?

editors/teco/Makefile
5–6

jp :) -- don't make the s/PORT/DIST/ change, unless the version value also changes.

editors/teco/Makefile
5–6

as for bumping due to documentation change.. I would say yes-ish, but it depends.

The porters handbook gives you some leaway there:

A rule of thumb is to decide whether a change committed to a port is something which some people would benefit from having. Either because of an enhancement, fix, or by virtue that the new package will actually work at all. Then weigh that against that fact that it will cause everyone who regularly updates their ports tree to be compelled to update. If yes, PORTREVISION must be bumped.
  • if you add a manpage to www/chromium, well, maybe skip the bump :) -- because the hassle of building the thing for 5hours is probably not worth the new manpage
  • if you add a manpage to something smallish like editors/kate, bump that thingy
5–6

s/add/change in the text above

... as the plist changes here however, it must be bumped :)

editors/teco/Makefile
5–6

Well, it is the line I commented on.

5–6

This sentence is so abused, I think I will remove it one day when I've had enough.
It says some people not most or everyone. The important information is:

PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way. That includes changes that only affect a package built with non-default options.

switch back to PORTVERSION

This revision is now accepted and ready to land.Sep 21 2018, 3:59 AM

Overcome by the more detailed D17228