Differential D17228

editors/teco: provide detailed manual page and set maintainership
ClosedPublic
Actions

Authored by fernape on Sep 18 2018, 8:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 19, 10:01 AM

	Unknown Object (File)
	Fri, Apr 19, 10:01 AM

	Unknown Object (File)
	Fri, Apr 19, 10:01 AM

	Unknown Object (File)
	Fri, Apr 19, 10:01 AM

	Unknown Object (File)
	Fri, Apr 19, 9:57 AM

	Unknown Object (File)
	Fri, Apr 19, 9:48 AM

	Unknown Object (File)
	Mar 20 2024, 1:58 PM

	Unknown Object (File)
	Jan 30 2024, 12:16 AM

View All 41 Files

Subscribers

Details

Reviewers

tcberner
tz

Commits

rP480869: editors/teco: Improve documentation and set maintainership

Summary

Set new maintainer
Add man page
Add LICENSE

Test Plan

portlint -AC OK
poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
run test on 11.2 amd64 OK

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fernape created this revision.Sep 18 2018, 8:34 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 18 2018, 8:34 PM

Harbormaster completed remote builds in B19653: Diff 48186.Sep 18 2018, 8:34 PM

mat added inline comments.Sep 18 2018, 9:10 PM

editors/teco/files/README.bsd.in
30–34 ↗	(On Diff #48186)	As this file is only present if the DOCS option is on, and it is in DOCSDIR, I'm unsure what this paragraph adds exactly.
editors/teco/pkg-message
1–2 ↗	(On Diff #48186)	Mmmm, 'read the man page' does not seem to be a very interesting pkg-message, maybe it should be removed. (Or README.bsd should be put in there.)

Moving note about installed documentation from README.bsd.in to pkg-message

Harbormaster completed remote builds in B19675: Diff 48222.Sep 19 2018, 4:09 PM

fernape marked 2 inline comments as done.Sep 19 2018, 4:10 PM

fernape added inline comments.

editors/teco/pkg-message
1–2 ↗	(On Diff #48186)	I added the piece from README.bsd.in

Does this look good?

I don't really get why there is a new file README.bsd.in at all, pkg-message is the right place to put that information.

editors/teco/Makefile
16 ↗	(On Diff #48222)	This was probably at the right place before.
17–18 ↗	(On Diff #48222)	This is not a standard framework variable, should happen later.

Relocating OPTIONS_DEFINE and DOCSFILES
Removing README file and adding its contents to pkg-message

Harbormaster completed remote builds in B19730: Diff 48318.Sep 21 2018, 4:03 PM

fernape marked 2 inline comments as done.Sep 21 2018, 4:04 PM

fernape mentioned this in D17072: editors/teco: Improved documentation.Sep 23 2018, 5:32 PM

Does this look good now?

Looks fine :)

This revision is now accepted and ready to land.Sep 28 2018, 5:17 AM

Closed by commit rP480869: editors/teco: Improve documentation and set maintainership (authored by fernape). · Explain WhySep 28 2018, 5:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

editors/

teco/

14 lines

files/

26 lines

patch-src_makefile

26 lines

patch-src_skpcmd.c

92 lines

patch-src_zlinux.c

32 lines

32 lines

506 lines

8 lines

44 lines

1 line

Diff 48558

head/editors/teco/Makefile

Loading...

head/editors/teco/files/patch-makefile

Loading...

head/editors/teco/files/patch-src_makefile

Loading...

head/editors/teco/files/patch-src_skpcmd.c

Loading...

head/editors/teco/files/patch-src_zlinux.c

Loading...

head/editors/teco/files/patch-zlinux

Loading...

head/editors/teco/files/teco.1.in

Loading...

head/editors/teco/pkg-descr

Loading...

head/editors/teco/pkg-message

Loading...

head/editors/teco/pkg-plist

Loading...