Page MenuHomeFreeBSD

rtld-elf: make it compile with WARNS=3
ClosedPublic

Authored by arichardson on Sep 13 2018, 1:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 8:54 PM
Unknown Object (File)
Sun, Dec 22, 5:15 PM
Unknown Object (File)
Fri, Dec 6, 1:58 PM
Unknown Object (File)
Fri, Dec 6, 1:58 PM
Unknown Object (File)
Fri, Dec 6, 1:58 PM
Unknown Object (File)
Fri, Dec 6, 1:58 PM
Unknown Object (File)
Dec 4 2024, 1:34 PM
Unknown Object (File)
Oct 26 2024, 2:14 PM
Subscribers

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19564
Build 19149: arc lint + arc unit

Event Timeline

libexec/rtld-elf/libmap.c
203

Merge 'i' declaration with the 'cnt' line.

libexec/rtld-elf/malloc.c
163

Use the opportunity to remove 'register' qualifier ?

libexec/rtld-elf/rtld.c
271

Wny this type change is needed ?

libexec/rtld-elf/malloc.c
163

Okay, will do.

libexec/rtld-elf/rtld.c
271

signed-unsigned comparison. I could also add a cast instead?

libexec/rtld-elf/rtld.c
271

I think that new type for the var should be Elf_Addr, if any. Look at its use. In fact this is an ABI issue.

Practically Elf_Addr has the same representation as size_t on all supported platforms, but this is not strictly required.

arichardson marked 6 inline comments as done.
  • Address feedback
  • remove register specifier from malloc.c
kib added inline comments.
libexec/rtld-elf/libmap.h
8

I would do a follow-up commit removing space before '('. Or you might add it to this change.

This revision is now accepted and ready to land.Sep 13 2018, 3:39 PM

I'd mention the de-register part of the change in the commit message as well as the warns fixes.

This revision was automatically updated to reflect the committed changes.