Page MenuHomeFreeBSD
Differential D13953

Mk/bsd.options.mk: Do not enable options that do not exist.
ClosedPublic
Actions

Authored by mat on Jan 17 2018, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 9:40 PM
Unknown Object (File)
Sat, May 4, 9:29 PM
Unknown Object (File)
Sat, May 4, 9:09 PM
Unknown Object (File)
Sat, May 4, 8:45 PM
Unknown Object (File)
Sat, May 4, 8:45 PM
Unknown Object (File)
Thu, Apr 25, 3:45 PM
Unknown Object (File)
Thu, Apr 25, 1:21 PM
Unknown Object (File)
Thu, Apr 25, 2:30 AM
View All 71 Files
Subscribers
antoine
bdrewery
swills

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP479428: Do not enable options that do not exist.
Summary

Many bits of the framework check for PORT_OPTIONS:MDOCS, which is on even if
the option is not defined.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat created this revision.Jan 17 2018, 4:44 PM
Harbormaster completed remote builds in B14439: Diff 38093.Jan 17 2018, 4:44 PM
antoine added a subscriber: antoine.Jan 17 2018, 6:09 PM

won't this change all the rubygem packages?

antoine added a comment.Jan 17 2018, 6:12 PM

all r-cran and drupal packages too

swills added a subscriber: swills.Jan 17 2018, 9:14 PM
In D13953#292630, @antoine wrote:

won't this change all the rubygem packages?

Almost all, some have DOCS options, but I think it's OK. I doubt anyone will miss the docs anyway.

mat updated this revision to Diff 38138.Jan 18 2018, 1:31 PM
  • Allow those options to be in a group, or something.
mat added a comment.Jan 18 2018, 1:54 PM
In D13953#292630, @antoine wrote:

won't this change all the rubygem packages?
all r-cran and drupal packages too

Those that do not have a DOCS option, yes. Same for all ports that use PORTDOCS/PORTEXAMPLES or %%PORTDOCS%%/%%PORTEXAMPLES%%.

The "new" options framework was commited in rP297660 on May 29 2012, 161k commits ago. It is way past time to remove the "compat" layer for how it was before.

bdrewery added a subscriber: bdrewery.Jan 24 2018, 8:41 PM

I'd only be ok with this after proof is posted that nothing is referring to ${PORT_OPTIONS:MDOCS} or <target>-DOCS-* without the _DOCS_ option in the list.

mat added a comment.Jan 25 2018, 1:44 PM
In D13953#294744, @bdrewery wrote:

I'd only be ok with this after proof is posted that nothing is referring to ${PORT_OPTIONS:MDOCS} or <target>-DOCS-* without the _DOCS_ option in the list.

Well, people using the DOCS option without actually using it are doing it wrong, I am not sure we want to fix everyone's mess.

I have D13651 that somewhat takes it one step further and has a lot of OPTIONS_DEFINE=DOCS added.

linimon retitled this revision from Do not enable options that do not exist. to Mk/bsd.options.mk: Do not enable options that do not exist..Aug 2 2018, 10:24 PM
mat updated this revision to Diff 47866.Sep 10 2018, 2:21 PM

rebase

Harbormaster completed remote builds in B19494: Diff 47866.Sep 10 2018, 2:21 PM
mat added a comment.Sep 10 2018, 2:23 PM

So, all the ports who were missing DOCS and EXAMPLES options have been fixed in rP479406 and rP479407.

mat updated this revision to Diff 47869.Sep 10 2018, 2:38 PM

rebase

  • Add IPV6 option to ports using it but not defining it.
  • Add NLS option to ports using it but not defining it.
  • Do not enable options that do not exist.
Harbormaster completed remote builds in B19496: Diff 47869.Sep 10 2018, 2:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 10 2018, 2:41 PM
Closed by commit rP479428: Do not enable options that do not exist. (authored by mat). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptSep 10 2018, 2:41 PM

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
17 linesO5: Ports Framework

Diff 47870

View Options

head/Mk/bsd.options.mk

Loading...