Page MenuHomeFreeBSD
Differential D17084

doc update for bcm238x_pwm(4) to reflect changes made to driver
ClosedPublic
Actions

Authored by bobf_mrp3.com on Sep 9 2018, 1:45 AM.
Tags
Referenced Files
F103996121: D17084.id47824.diff
Mon, Dec 2, 4:30 AM
Unknown Object (File)
Tue, Nov 26, 7:04 PM
Unknown Object (File)
Oct 20 2024, 2:49 PM
Unknown Object (File)
Oct 20 2024, 2:49 PM
Unknown Object (File)
Oct 20 2024, 2:49 PM
Unknown Object (File)
Oct 20 2024, 2:33 PM
Unknown Object (File)
Oct 17 2024, 12:23 AM
Unknown Object (File)
Oct 3 2024, 8:55 AM
View All 36 Files
Subscribers
0mp
andrew
imp

Details

Reviewers
gonzo
0mp
Group Reviewers
manpages
Commits
rS338574: [bcm283x_pwm] Add documentation for the second PWM channel
Summary

a month or so ago changes were committed to the bcm283x_pwm driver but these changes weren't reflected in the documentation. This modifies the man page to reflect the changes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bobf_mrp3.com created this revision.Sep 9 2018, 1:45 AM
Herald added a reviewer: manpages. · View Herald TranscriptSep 9 2018, 1:45 AM
Herald added subscribers: andrew, imp. · View Herald Transcript
gonzo accepted this revision.Sep 10 2018, 7:45 PM
This revision is now accepted and ready to land.Sep 10 2018, 7:45 PM
0mp accepted this revision as: 0mp.Sep 10 2018, 9:45 PM
0mp added a subscriber: 0mp.

Looks fine when it comes to mdoc syntax.

Do you think you could address the issues I pointed out in this revision as well?

Thanks!

share/man/man4/man4.arm/bcm283x_pwm.4
41

Shouldn't we write Raspberry Pi instead of Rpi?

80

Missing period.

88

Not part of your changes but there's a period missing at the end of the sentence.

0mp added inline comments.Sep 10 2018, 9:55 PM
share/man/man4/man4.arm/bcm283x_pwm.4
29

Also, remember to bump Dd.

Closed by commit rS338574: [bcm283x_pwm] Add documentation for the second PWM channel (authored by gonzo). · Explain WhySep 10 2018, 10:48 PM
This revision was automatically updated to reflect the committed changes.
gonzo added a comment.Sep 11 2018, 6:48 PM
In D17084#364832, @0mp wrote:

Looks fine when it comes to mdoc syntax.

Do you think you could address the issues I pointed out in this revision as well?

Thanks!

Thanks for review Mateusz,

I added your revisions to the commit

0mp added a comment.Sep 11 2018, 7:58 PM

Happy to help :)

Revision Contents
Changeset List

PathSize
share/
man/
man4/
man4.arm/
bcm283x_pwm.4
bcm283x_pwm.4.orig
35 lines

Diff 47824

View Options

share/man/man4/man4.arm/bcm283x_pwm.4

Loading...