Fix style bugs in in_pcblookup_lbgroup().
ClosedPublic
Actions

Authored by markj on Sep 4 2018, 8:57 PM.

Tags

None

Referenced Files

	F150173325: D17030.id47665.diff
	Mon, Mar 30, 12:41 AM

	Unknown Object (File)
	Wed, Mar 25, 1:41 AM

	Unknown Object (File)
	Fri, Mar 20, 8:48 AM

	Unknown Object (File)
	Thu, Mar 19, 5:02 AM

	Unknown Object (File)
	Sun, Mar 8, 10:16 AM

	Unknown Object (File)
	Sun, Mar 8, 4:32 AM

	Unknown Object (File)
	Thu, Mar 5, 1:52 AM

	Unknown Object (File)
	Feb 28 2026, 11:35 AM

View All Files

Subscribers

imp

Details

Reviewers

sbruno
johalun0_gmail.com
bz

Group Reviewers

network

Commits

rS338470: Fix style bugs in in_pcblookup_lbgroup().

Summary

I am working on some issues in this area (see PR 231064).
in_pcblookup_lbgroup() is quite hard to read, so I would like to clean
it up first. No functional change intended.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19394
Build 18994: arc lint + arc unit

Event Timeline

markj created this revision.Sep 4 2018, 8:57 PM

Harbormaster completed remote builds in B19394: Diff 47665.Sep 4 2018, 8:57 PM

markj added reviewers: network, sbruno, johalun0_gmail.com.Sep 4 2018, 9:00 PM

LGTM

This revision is now accepted and ready to land.Sep 4 2018, 11:53 PM

Thanks for cleaning this up.

Closed by commit rS338470: Fix style bugs in in_pcblookup_lbgroup(). (authored by markj). · Explain WhySep 6 2018, 12:25 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2018, 12:25 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

45 lines

Diff 47665

View Options

Fix style bugs in in_pcblookup_lbgroup().ClosedPublicActions