Page MenuHomeFreeBSD
Differential D16986

fortuna: Drop global lock to zero stack variables
ClosedPublic
Actions

Authored by cem on Sep 1 2018, 7:01 PM.
Tags
None
Referenced Files
F151007555: D16986.id47566.diff
Sun, Apr 5, 10:38 AM
F151004045: D16986.id49665.diff
Sun, Apr 5, 10:12 AM
Unknown Object (File)
Sat, Apr 4, 3:06 PM
Unknown Object (File)
Sat, Apr 4, 12:47 AM
Unknown Object (File)
Fri, Apr 3, 9:25 PM
Unknown Object (File)
Fri, Apr 3, 6:10 AM
Unknown Object (File)
Tue, Mar 24, 1:59 AM
Unknown Object (File)
Tue, Mar 24, 12:14 AM
View All Files
Subscribers
delphij
imp

Details

Reviewers
markm
delphij
jmg
Group Reviewers
secteam
O3: Kernel Random Numbers Generator(Owns No Changed Paths)
Commits
rG1ae8bd9a7d5a: fortuna: Drop global lock to zero stack variables
rS339789: fortuna: Drop global lock to zero stack variables
Summary

Suggested by: delphij@

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19347
Build 18952: arc lint + arc unit

Event Timeline

cem created this revision.Sep 1 2018, 7:01 PM
Harbormaster completed remote builds in B19347: Diff 47566.Sep 1 2018, 7:01 PM
markm added inline comments.Sep 1 2018, 7:17 PM
sys/dev/random/fortuna.c
421

May as well drop this?

markm added inline comments.Sep 1 2018, 7:19 PM
sys/dev/random/fortuna.c
421

By "this" I mean just the zeroing of the context, as you pointed out?

cem added inline comments.Sep 1 2018, 7:21 PM
sys/dev/random/fortuna.c
421

Ah, right, https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230877 . Sure, I can drop it.

cem updated this revision to Diff 47568.Sep 1 2018, 7:23 PM
cem marked 3 inline comments as done.

Drop extra bzero of hash context, as I pointed out earlier but forgot about
:-). Thanks markm@.

Harbormaster completed remote builds in B19348: Diff 47568.Sep 1 2018, 7:23 PM
markm accepted this revision.Sep 5 2018, 5:20 PM
This revision is now accepted and ready to land.Sep 5 2018, 5:20 PM
delphij accepted this revision.Sep 6 2018, 8:10 PM
delphij added a subscriber: delphij.

LGTM.

Closed by commit rS339789: fortuna: Drop global lock to zero stack variables (authored by cem). · Explain WhyOct 26 2018, 9:00 PM
This revision was automatically updated to reflect the committed changes.
Owners added a reviewer: O3: Kernel Random Numbers Generator.Oct 26 2018, 9:00 PM
Herald added a reviewer: jmg. · View Herald TranscriptOct 26 2018, 9:00 PM
Herald added a subscriber: imp. · View Herald Transcript
obrien added a commit: rG1ae8bd9a7d5a: fortuna: Drop global lock to zero stack variables.Aug 6 2021, 5:14 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
random/
66 lines

Diff 47566

View Options

sys/dev/random/fortuna.c

Loading...