Differential D16936

Fortuna: Add trivial assert to match FS&K definition
ClosedPublic
Actions

Authored by cem on Aug 29 2018, 4:35 AM.

Tags

None

Referenced Files

	F161340058: D16936.diff
	Thu, Jul 2, 11:33 PM

	F161265241: D16936.diff
	Thu, Jul 2, 6:49 AM

	Unknown Object (File)
	Mon, Jun 15, 1:30 AM

	Unknown Object (File)
	Wed, Jun 10, 11:36 PM

	Unknown Object (File)
	Tue, Jun 9, 5:31 PM

	Unknown Object (File)
	Tue, Jun 9, 7:46 AM

	Unknown Object (File)
	Mon, Jun 8, 8:46 PM

	Unknown Object (File)
	May 11 2026, 3:45 PM

Subscribers

Details

Reviewers

markm
delphij
jmg

Group Reviewers

secteam
O3: Kernel Random Numbers Generator	(Owns No Changed Paths)

Commits

rG2cc41234353f: Fortuna: Add trivial assert to match FS&K definition
rS339480: Fortuna: Add trivial assert to match FS&K definition

Summary

FS&K GenerateBlocks function asserts C (counter) != 0. This should also
be true in our implementation.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19257
Build 18870: arc lint + arc unit

Event Timeline

cem created this revision.Aug 29 2018, 4:35 AM

Harbormaster completed remote builds in B19257: Diff 47425.Aug 29 2018, 4:35 AM

delphij accepted this revision.Aug 29 2018, 5:49 PM

This revision is now accepted and ready to land.Aug 29 2018, 5:49 PM

markm accepted this revision.Aug 29 2018, 7:28 PM

Closed by commit rS339480: Fortuna: Add trivial assert to match FS&K definition (authored by cem). · Explain WhyOct 20 2018, 8:13 PM

This revision was automatically updated to reflect the committed changes.

Owners added a reviewer: O3: Kernel Random Numbers Generator.Oct 20 2018, 8:13 PM

Herald added a reviewer: jmg. · View Herald TranscriptOct 20 2018, 8:13 PM

Herald added a subscriber: imp. · View Herald Transcript

obrien added a commit: rG2cc41234353f: Fortuna: Add trivial assert to match FS&K definition.Aug 6 2021, 12:50 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

random/

2 lines

Diff 47425

sys/dev/random/fortuna.c

Loading...