Page MenuHomeFreeBSD
Differential D16740

GPT is standard in x86 and arm64 land. Add it to DEFAULTS with the others.
ClosedPublic
Actions

Authored by imp on Aug 16 2018, 1:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 25, 7:53 PM
Unknown Object (File)
Tue, Mar 24, 4:26 AM
Unknown Object (File)
Mon, Mar 23, 6:33 PM
Unknown Object (File)
Mon, Mar 23, 9:05 AM
Unknown Object (File)
Mon, Mar 23, 1:39 AM
Unknown Object (File)
Mon, Mar 23, 12:59 AM
Unknown Object (File)
Sat, Mar 21, 12:06 PM
Unknown Object (File)
Fri, Mar 20, 12:34 AM
View All Files
Subscribers
andrew
emaste
jmg
ler

Details

Reviewers
manu
ler
rgrimes
Commits
rS337967: GPT is standard in x86 and arm64 land. Add it to DEFAULTS with the

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18840
Build 18502: arc lint + arc unit

Event Timeline

imp created this revision.Aug 16 2018, 1:32 AM
Herald added a reviewer: manu. · View Herald TranscriptAug 16 2018, 1:32 AM
Herald added subscribers: emaste, andrew. · View Herald Transcript
Harbormaster completed remote builds in B18839: Diff 46753.Aug 16 2018, 1:32 AM
ler requested changes to this revision.Aug 16 2018, 1:34 AM
ler added a subscriber: ler.

What about i386?

This revision now requires changes to proceed.Aug 16 2018, 1:34 AM
imp updated this revision to Diff 46754.Aug 16 2018, 1:36 AM

i386m too

Harbormaster completed remote builds in B18840: Diff 46754.Aug 16 2018, 1:36 AM
ler accepted this revision.Aug 16 2018, 1:38 AM

LGTM, what say others?

This revision is now accepted and ready to land.Aug 16 2018, 1:38 AM
rgrimes accepted this revision.Aug 16 2018, 2:59 PM
manu accepted this revision.Aug 16 2018, 3:05 PM
jmg added a subscriber: jmg.Aug 16 2018, 4:49 PM

Should powerpc64 be added too?

(I'm not familiar w/ it, so don't know how heavily used GPT is there.)

imp added a comment.Aug 16 2018, 7:16 PM
In D16740#356185, @jmg wrote:

Should powerpc64 be added too?

(I'm not familiar w/ it, so don't know how heavily used GPT is there.)

I don't think so. Apple powerpc64 didn't use nit, and newer stuff is a hodge-podge still.

Closed by commit rS337967: GPT is standard in x86 and arm64 land. Add it to DEFAULTS with the (authored by imp). · Explain WhyAug 17 2018, 2:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
amd64/
conf/
1 line
arm64/
conf/
1 line
i386/
conf/
1 line

Diff 46754

View Options

sys/amd64/conf/DEFAULTS

Loading...
View Options

sys/arm64/conf/DEFAULTS

Loading...
View Options

sys/i386/conf/DEFAULTS

Loading...