GPT is standard in x86 and arm64 land. Add it to DEFAULTS with the others.
ClosedPublic
Actions

Authored by imp on Aug 16 2018, 1:32 AM.

Details

Reviewers

manu
ler
rgrimes

Commits

rS337967: GPT is standard in x86 and arm64 land. Add it to DEFAULTS with the

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18839
Build 18501: arc lint + arc unit

Event Timeline

imp created this revision.Aug 16 2018, 1:32 AM

Herald added a reviewer: manu. · View Herald TranscriptAug 16 2018, 1:32 AM

Herald added subscribers: emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B18839: Diff 46753.Aug 16 2018, 1:32 AM

What about i386?

This revision now requires changes to proceed.Aug 16 2018, 1:34 AM

i386m too

Harbormaster completed remote builds in B18840: Diff 46754.Aug 16 2018, 1:36 AM

LGTM, what say others?

This revision is now accepted and ready to land.Aug 16 2018, 1:38 AM

rgrimes accepted this revision.Aug 16 2018, 2:59 PM

manu accepted this revision.Aug 16 2018, 3:05 PM

Should powerpc64 be added too?

(I'm not familiar w/ it, so don't know how heavily used GPT is there.)

In D16740#356185, @jmg wrote:

Should powerpc64 be added too?

(I'm not familiar w/ it, so don't know how heavily used GPT is there.)

I don't think so. Apple powerpc64 didn't use nit, and newer stuff is a hodge-podge still.

Closed by commit rS337967: GPT is standard in x86 and arm64 land. Add it to DEFAULTS with the (authored by imp). · Explain WhyAug 17 2018, 2:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

DEFAULTS

1 line

arm64/

conf/

DEFAULTS

1 line

Diff 46753

View Options

sys/amd64/conf/DEFAULTS