Additionally invert the csh shell change for root
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 18812 Build 18476: arc lint + arc unit
Event Timeline
| bin/csh/Makefile | ||
|---|---|---|
| 160 | This is in the wrong place, tcsh csh link has 0 to do with installconfig. | |
| 161 | Why is installconfig editing the master.password file at all? It certainly did not install it, and should not in anyway be doing anything that effects the contents. | |
| etc/master.passwd | ||
| 3 | Please do not do this. | |
| bin/csh/Makefile | ||
|---|---|---|
| 160 | Yup, I was too quick here... will update | |
| 161 | Yet... It will once I move master.passwd to CONFS | |
| etc/master.passwd | ||
| 3 | Why, this whole change makes it to what we have today.. i.e. if csh is enabled the sed above switches to it, but otherwise it leaves it as sh. I just inverted how it was done. | |
| etc/master.passwd | ||
|---|---|---|
| 3 | What value would that provide? | |
| etc/master.passwd | ||
|---|---|---|
| 3 | Actually the more I think about this, the whole edit of master.passwd should be done in the Makefile that is installing it, and these edits in the tcsh/Makefile ripped out. It is simply the wrong place for it. You do not see minimizing changes to src files as having value? | |
Comment Actions
This is still wrong.
- It would be better to use pw user mod 0 -s /path/shell instead of sed.
- The toor user exists in master.passwd to allow to log in with sh or bash.