Page MenuHomeFreeBSD

Rack delayed ack issue
ClosedPublic

Authored by rrs on Aug 3 2018, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 8, 12:02 AM
Unknown Object (File)
Dec 20 2023, 1:45 AM
Unknown Object (File)
Nov 7 2023, 7:43 AM
Unknown Object (File)
Oct 19 2023, 8:25 PM
Unknown Object (File)
Oct 19 2023, 5:50 PM
Unknown Object (File)
Oct 6 2023, 6:37 AM
Unknown Object (File)
May 27 2023, 6:19 AM
Subscribers

Details

Summary

Turns out that Rack fails to translate to ms the delayed ack
value from the system default in ticks. This works fine
when hz=1000 but other hz values cause problems.

Test Plan

Use pkt-drill to validate the new fix on a machine with hz=100 (like a vm)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen requested changes to this revision.Aug 3 2018, 12:16 PM
tuexen added inline comments.
sys/netinet/tcp_stacks/rack.c
2278 ↗(On Diff #46229)

I guess you mean

delayed_ack = TICKS_2_MSEC(tcp_delacktime);

I can confirm that with that change the issue is resolved.

This revision now requires changes to proceed.Aug 3 2018, 12:16 PM
sys/netinet/tcp_stacks/rack.c
2278 ↗(On Diff #46229)

Yep. typo'd the update.. let me get it in place and changed.

This revision is now accepted and ready to land.Aug 5 2018, 11:57 AM
This revision was automatically updated to reflect the committed changes.