Page MenuHomeFreeBSD
Differential D16523

Add devel/hs-fortran-src port - a library for lexing and parsing Fortran source code.
ClosedPublic
Actions

Authored by arrowd on Jul 31 2018, 8:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 26, 1:14 PM
Unknown Object (File)
Sat, Jul 25, 2:04 AM
Unknown Object (File)
Tue, Jul 21, 4:52 AM
Unknown Object (File)
Mon, Jul 20, 3:14 AM
Unknown Object (File)
Mon, Jul 20, 12:28 AM
Unknown Object (File)
Sun, Jul 19, 1:01 PM
Unknown Object (File)
Thu, Jul 16, 2:39 AM
Unknown Object (File)
Sun, Jul 5, 1:25 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
AMDmi3
Group Reviewers
Contributor Reviewers (ports)
Commits
rP476202: Add devel/hs-fortran-src port - a library for lexing and parsing Fortran source…

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 18478
Build 18183: arc lint + arc unit

Event Timeline

arrowd created this revision.Jul 31 2018, 8:59 AM
Harbormaster completed remote builds in B18453: Diff 46062.Jul 31 2018, 8:59 AM
mat added a subscriber: mat.Jul 31 2018, 9:49 AM
mat added inline comments.
devel/hs-GenericPretty/Makefile
2

Missing the header.

devel/hs-GenericPretty/pkg-descr
5

Remove.

devel/hs-fortran-src/Makefile
2

Missing header.

devel/hs-fortran-src/pkg-descr
5

Remove.

arrowd added inline comments.Jul 31 2018, 8:57 PM
devel/hs-GenericPretty/Makefile
2

What header? $ FreeBSD $?

devel/hs-GenericPretty/pkg-descr
5

Newline or WWW line?

tcberner added inline comments.Aug 1 2018, 5:29 AM
devel/hs-GenericPretty/Makefile
2

Yup, that one is always required, see sample Makefile

devel/hs-GenericPretty/pkg-descr
5

new line :)

tcberner added a comment.Aug 1 2018, 5:30 AM

When adding new [or removing] ports, you always need to carry the changes in the category Makefile's SUBDIR list.

tcberner added inline comments.Aug 1 2018, 5:32 AM
devel/hs-GenericPretty/Makefile
4

^ new ports should not have a portrevision

7

^ is that the correct email? :D

mat added inline comments.Aug 1 2018, 7:43 AM
devel/hs-GenericPretty/pkg-descr
5

My comment is related to line 4, so, yes, blank line.

arrowd updated this revision to Diff 46122.Aug 1 2018, 8:54 AM
arrowd marked 11 inline comments as done.

Address comments.

Harbormaster completed remote builds in B18478: Diff 46122.Aug 1 2018, 8:54 AM
arrowd added inline comments.Aug 1 2018, 8:54 AM
devel/hs-GenericPretty/Makefile
7

Yes, the port was submitted by other guy.

mat added inline comments.Aug 1 2018, 9:05 AM
devel/hs-GenericPretty/pkg-descr
1

pkg-descr must be a few lines long, at least a paragraph.

devel/hs-fortran-src/pkg-descr
1

I do not think anlyses is a word.
Also, pkg-descr must be a few lines long, at least a paragraph.

tcberner added inline comments.Aug 1 2018, 12:00 PM
devel/hs-fortran-src/pkg-descr
1

I had the same reaction -- it's the description of the thingy on it's website.

Further down they spell it more conventionally as analyses.

tcberner requested changes to this revision.Aug 1 2018, 12:01 PM

You're still missing the entries in devel/Makefile.

This revision now requires changes to proceed.Aug 1 2018, 12:01 PM
arrowd updated this revision to Diff 46138.Aug 1 2018, 6:04 PM
arrowd marked 2 inline comments as done.

Address comments.

Harbormaster completed remote builds in B18488: Diff 46138.Aug 1 2018, 6:04 PM
tcberner accepted this revision.Aug 1 2018, 7:02 PM

Looks good to me.

This revision is now accepted and ready to land.Aug 1 2018, 7:02 PM
Closed by commit rP476202: Add devel/hs-fortran-src port - a library for lexing and parsing Fortran source… (authored by arrowd). · Explain WhyAug 1 2018, 9:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
hs-GenericPretty/
13 lines
3 lines
3 lines
hs-fortran-src/
19 lines
3 lines
3 lines
lang/
ghc/
2 lines

Diff 46122

View Options

devel/hs-GenericPretty/Makefile

Loading...
View Options

devel/hs-GenericPretty/distinfo

Loading...
View Options

devel/hs-GenericPretty/pkg-descr

Loading...
View Options

devel/hs-fortran-src/Makefile

Loading...
View Options

devel/hs-fortran-src/distinfo

Loading...
View Options

devel/hs-fortran-src/pkg-descr

Loading...
View Options

lang/ghc/bsd.hackage.mk

Loading...