Page MenuHomeFreeBSD

Add devel/hs-fortran-src port - a library for lexing and parsing Fortran source code.
ClosedPublic

Authored by arrowd on Jul 31 2018, 8:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 7:23 AM
Unknown Object (File)
Feb 10 2024, 12:59 AM
Unknown Object (File)
Feb 8 2024, 6:21 PM
Unknown Object (File)
Dec 31 2023, 6:37 AM
Unknown Object (File)
Dec 28 2023, 6:13 PM
Unknown Object (File)
Dec 20 2023, 1:48 AM
Unknown Object (File)
Nov 22 2023, 1:20 PM
Unknown Object (File)
Nov 10 2023, 8:40 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat added inline comments.
devel/hs-GenericPretty/Makefile
1 ↗(On Diff #46062)

Missing the header.

devel/hs-GenericPretty/pkg-descr
4 ↗(On Diff #46062)

Remove.

devel/hs-fortran-src/Makefile
1 ↗(On Diff #46062)

Missing header.

devel/hs-fortran-src/pkg-descr
4 ↗(On Diff #46062)

Remove.

devel/hs-GenericPretty/Makefile
1 ↗(On Diff #46062)

What header? $ FreeBSD $?

devel/hs-GenericPretty/pkg-descr
4 ↗(On Diff #46062)

Newline or WWW line?

devel/hs-GenericPretty/Makefile
1 ↗(On Diff #46062)

Yup, that one is always required, see sample Makefile

devel/hs-GenericPretty/pkg-descr
4 ↗(On Diff #46062)

new line :)

When adding new [or removing] ports, you always need to carry the changes in the category Makefile's SUBDIR list.

devel/hs-GenericPretty/Makefile
3 ↗(On Diff #46062)

^ new ports should not have a portrevision

6 ↗(On Diff #46062)

^ is that the correct email? :D

devel/hs-GenericPretty/pkg-descr
4 ↗(On Diff #46062)

My comment is related to line 4, so, yes, blank line.

arrowd marked 11 inline comments as done.

Address comments.

devel/hs-GenericPretty/Makefile
6 ↗(On Diff #46062)

Yes, the port was submitted by other guy.

devel/hs-GenericPretty/pkg-descr
1 ↗(On Diff #46122)

pkg-descr must be a few lines long, at least a paragraph.

devel/hs-fortran-src/pkg-descr
1 ↗(On Diff #46122)

I do not think anlyses is a word.
Also, pkg-descr must be a few lines long, at least a paragraph.

devel/hs-fortran-src/pkg-descr
1 ↗(On Diff #46122)

I had the same reaction -- it's the description of the thingy on it's website.

Further down they spell it more conventionally as analyses.

You're still missing the entries in devel/Makefile.

This revision now requires changes to proceed.Aug 1 2018, 12:01 PM
arrowd marked 2 inline comments as done.

Address comments.

This revision is now accepted and ready to land.Aug 1 2018, 7:02 PM
This revision was automatically updated to reflect the committed changes.