Page MenuHomeFreeBSD
Differential D16476

Handle a bug with install(1) -C and /dev/null
ClosedPublic
Actions

Authored by brd on Jul 27 2018, 10:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 3:04 PM
Unknown Object (File)
Mar 7 2024, 11:36 PM
Unknown Object (File)
Jan 10 2024, 6:26 AM
Unknown Object (File)
Jan 10 2024, 6:26 AM
Unknown Object (File)
Jan 10 2024, 6:26 AM
Unknown Object (File)
Jan 10 2024, 6:14 AM
Unknown Object (File)
Dec 20 2023, 2:29 AM
Unknown Object (File)
Sep 1 2023, 1:47 PM
View All 15 Files
Subscribers
bdrewery
emaste
imp
vishwin

Details

Reviewers
allanjude
bapt
will
Commits
rS336794: Avoid a install(1) crash by not using -C when the source is /dev/null
Summary

Apparently when the file already exists, the /dev/null handling in install(1)
is not sufficient. So this works around it, and does not use -C when /dev/null
is the source.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brd created this revision.Jul 27 2018, 10:05 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptJul 27 2018, 10:05 PM
Harbormaster completed remote builds in B18385: Diff 45930.Jul 27 2018, 10:05 PM
allanjude accepted this revision.Jul 27 2018, 10:39 PM

Approved By: allanjude

This revision is now accepted and ready to land.Jul 27 2018, 10:39 PM
vishwin added a subscriber: vishwin.Jul 27 2018, 10:43 PM

make distribution no longer crashes with this.

Closed by commit rS336794: Avoid a install(1) crash by not using -C when the source is /dev/null (authored by brd). · Explain WhyJul 27 2018, 10:47 PM
This revision was automatically updated to reflect the committed changes.
will added a comment.Jul 28 2018, 3:15 PM

This seems like a bug that should be fixed in install(1), not here. It's unclear from the description what the actual bug is.

Revision Contents
Changeset List

PathSize
head/
share/
mk/
8 lines

Diff 45931

View Options

head/share/mk/bsd.confs.mk

Loading...