This reduce the per-board arm_install_uboot to just install u-boot.
While here remove the installation of rpi.dtb and rpi2.dtb as we load
them from the UFS partition via ubldr.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
This is a good first step...
I wonder, though about the one item I highlighted.
| release/tools/arm.subr | ||
|---|---|---|
| 189 | ${FATMOUNT}/EFI/BOOT/$(efi_boot_name ${EMBEDDED_TARGET}) might be better, then you don't need the if/then/else here. This might be useful since it would allow any target. | |
| 195 | why are we touching firstboot here? | |
| 196 | strictly speaking, this should not be needed... | |
| release/tools/arm.subr | ||
|---|---|---|
| 195 | The growfs(8) rc script depends on it. | |
| release/tools/arm.subr | ||
|---|---|---|
| 195 | that's not my question, why is it needed *HERE*. It's got nothing to do with booting, and is the only reason we mount the UFS fileysstem in this routine. | |
| release/tools/arm.subr | ||
|---|---|---|
| 189 | Yes it does. the efi_boot_name fuction would return bootaa64.efi for the first arg being arm64. It would returm bootarm.efi if the first arg is arm. | |
| release/tools/arm.subr | ||
|---|---|---|
| 195 | I do not recall why I did it this way. I'm sure I had a reason to do it this way, but it escapes me at the moment. | |
Comment Actions
Meh, I guess you're right about the UI, I just accepted the review when I just wanted to mark comment as done :)