top(1): rollback r335836
ClosedPublic
Actions

Authored by daichi on Jul 10 2018, 1:03 AM.

Details

Reviewers

hrs
jilles
eadler
gnn

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rS336160: top(1): rollback r335836

Summary

top(1): rollback r335836

required by: hrs

After rollback is completed, next I will create a patch review that adds selocale() and removes printable().

Reference:
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165751.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165766.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165833.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165846.html
https://www.mail-archive.com/svn-src-all@freebsd.org/msg165891.html

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

daichi created this revision.Jul 10 2018, 1:03 AM

Please split this changes into two commits; one is to revert r335836 and another is to add setlocale() and remove printable() function. A single commit including the both is confusing.

This revision now requires changes to proceed.Jul 10 2018, 1:16 AM

Following the advice of hrs, splitted into two commits; one is to revert r335836 and another is to add setlocale() and remove printable() function. I changed this review to rollback.

Reverting a change does not need any approval or review. Please document the reason in the commit log instead of just saying "rollback".

This revision is now accepted and ready to land.Jul 10 2018, 3:32 AM

Closed by commit rS336160: top(1): rollback r335836 (authored by daichi). · Explain WhyJul 10 2018, 3:50 AM

This revision was automatically updated to reflect the committed changes.

Owners added a reviewer: Restricted Owners Package.Jul 10 2018, 3:50 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 10 2018, 3:50 AM