Page MenuHomeFreeBSD

top(1): rollback r335836
ClosedPublic

Authored by daichi on Jul 10 2018, 1:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 30 2024, 1:02 PM
Unknown Object (File)
Jan 14 2024, 12:40 PM
Unknown Object (File)
Jan 7 2024, 3:52 AM
Unknown Object (File)
Dec 20 2023, 1:20 AM
Unknown Object (File)
Nov 27 2023, 1:26 AM
Unknown Object (File)
Nov 22 2023, 5:25 PM
Unknown Object (File)
Oct 20 2023, 10:28 AM
Unknown Object (File)
Oct 20 2023, 8:50 AM
Subscribers

Details

Reviewers
hrs
jilles
eadler
gnn
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rS336160: top(1): rollback r335836
Summary

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hrs requested changes to this revision.Jul 10 2018, 1:16 AM

Please split this changes into two commits; one is to revert r335836 and another is to add setlocale() and remove printable() function. A single commit including the both is confusing.

This revision now requires changes to proceed.Jul 10 2018, 1:16 AM
daichi retitled this revision from top(1): support multibyte characters in ARGV array depending on LC_CTYPE, not limited to UTF-8 to top(1): rollback r335836.
daichi edited the summary of this revision. (Show Details)
daichi edited the test plan for this revision. (Show Details)

Following the advice of hrs, splitted into two commits; one is to revert r335836 and another is to add setlocale() and remove printable() function. I changed this review to rollback.

Reverting a change does not need any approval or review. Please document the reason in the commit log instead of just saying "rollback".

This revision is now accepted and ready to land.Jul 10 2018, 3:32 AM
This revision was automatically updated to reflect the committed changes.
Owners added a reviewer: Restricted Owners Package.Jul 10 2018, 3:50 AM