This maintenance commit contains fixes and features for Microsemi's smartpqi module.
Details
Details
- Reviewers
sbruno scottl mav - Commits
- rS336201: smartpqi(4):
Smartpqi driver is tested and qualified by internal quality assurance team.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
On a quick look I spotted number of style issues you may fix.
| sys/dev/smartpqi/smartpqi_defines.h | ||
|---|---|---|
| 909 | This looks like a null change, but if you wish so, so be it. | |
| 920 | Here would be good to add braces around rcb on the rigth side. | |
| 948–950 | Here should be tab after define. Also it may be not very good to change flags meaning without significant reason. | |
| sys/dev/smartpqi/smartpqi_discovery.c | ||
| 48 | Here extra tabs. | |
| sys/dev/smartpqi/smartpqi_init.c | ||
| 568 | Extra tabs. | |
| 579 | Something happened to formatting. | |
| 681 | FreeBSD style(9) recommends to wrap the line before the function name and before the opening curly bracket. And also some extra tabs. | |
| 762 | Here some mess with tabs/spaces. | |
| sys/dev/smartpqi/smartpqi_mem.c | ||
| 61 | Very "useful" function. ;) | |
Comment Actions
Please stop adding redundant prototypes for the same function — it breaks the GCC build. The tagged lines below are not exhaustive.
| head/sys/dev/smartpqi/smartpqi_prototypes.h | ||
|---|---|---|
| 143 ↗ | (On Diff #45177) | This one's got a dupe too |
| 144 ↗ | (On Diff #45177) | E.g., this is defined again 100 lines lower in the same header. Why??? |
| 145 ↗ | (On Diff #45177) | Ditto. |
| 241–242 ↗ | (On Diff #45177) | We don't need both |