This maintenance commit contains fixes and features for Microsemi's smartpqi module.
On a quick look I spotted number of style issues you may fix.
This looks like a null change, but if you wish so, so be it.
Here would be good to add braces around rcb on the rigth side.
Here should be tab after define. Also it may be not very good to change flags meaning without significant reason.
Here extra tabs.
Something happened to formatting.
FreeBSD style(9) recommends to wrap the line before the function name and before the opening curly bracket. And also some extra tabs.
Here some mess with tabs/spaces.
Very "useful" function. ;)
Please stop adding redundant prototypes for the same function — it breaks the GCC build. The tagged lines below are not exhaustive.
|143 ↗||(On Diff #45177)|
This one's got a dupe too
|144 ↗||(On Diff #45177)|
E.g., this is defined again 100 lines lower in the same header. Why???
|145 ↗||(On Diff #45177)|
|241–242 ↗||(On Diff #45177)|
We don't need both