Paths

Table of Contentst

Differential D15867

Syscalls concerned with modifying/deleting the extended attributes of a file
ClosedPublic
Actions

Authored by aniketp on Jun 17 2018, 5:49 PM.

Tags

None

Referenced Files

	F167530537: D15867.id.diff
	Sat, Aug 22, 12:49 PM

	F167516691: D15867.id43985.diff
	Sat, Aug 22, 10:25 AM

	F167489478: D15867.diff
	Sat, Aug 22, 5:30 AM

	Unknown Object (File)
	Fri, Aug 21, 3:11 PM

	Unknown Object (File)
	Fri, Aug 21, 1:23 PM

	Unknown Object (File)
	Thu, Aug 20, 9:16 PM

	Unknown Object (File)
	Thu, Aug 20, 9:16 PM

	Unknown Object (File)
	Thu, Aug 20, 12:51 PM

Subscribers

Details

Reviewers

asomers
rwatson
gnn

Commits

rS335318: audit(4): add tests for extattr_set_file and friends

Summary

This revision introduces test-cases for checking the proper auditability of syscalls
concerned with modifying/deleting the extended attributes of a file or a symbolic link.
The system calls are categorized within file-attribute-modify audit class.
List of syscalls are:

extattr_set_file(2)
extattr_set_fd(2)
extattr_set_link(2)
extattr_delete_file(2)
extattr_delete_fd(2)
extattr_delete_link(2)

Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17396
Build 17228: arc lint + arc unit

Event Timeline

aniketp created this revision.Jun 17 2018, 5:49 PM

Harbormaster completed remote builds in B17378: Diff 43956.Jun 17 2018, 5:49 PM

asomers requested changes to this revision.Jun 17 2018, 9:39 PM

asomers added inline comments.

tests/sys/audit/file-attribute-modify.c
42	It's confusing to name this variable `readbuff`, because it isn't a buffer. Could you please pick a different name?

This revision now requires changes to proceed.Jun 17 2018, 9:39 PM

Replace readbuff with retval since it is a simple return value instead of a buffer
i.e return value of extattr_delete_{file/fd/link}

Harbormaster completed remote builds in B17396: Diff 43985.Jun 18 2018, 4:52 AM

asomers accepted this revision.Jun 18 2018, 2:59 PM

This revision is now accepted and ready to land.Jun 18 2018, 2:59 PM

Closed by commit rS335318: audit(4): add tests for extattr_set_file and friends (authored by asomers). · Explain WhyJun 18 2018, 3:07 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 18 2018, 3:07 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

audit/

file-attribute-modify.c

347 lines

Diff 43985

tests/sys/audit/file-attribute-modify.c

Loading...