Page MenuHomeFreeBSD
Differential D15859

Syscalls concerned with retrieving/listing the extended attributes of a file
ClosedPublic
Actions

Authored by aniketp on Jun 17 2018, 12:03 AM.
Tags
None
Referenced Files
F170655726: D15859.diff
Sat, Sep 5, 8:30 PM
F170603176: D15859.diff
Sat, Sep 5, 2:41 PM
F170463529: D15859.id43945.diff
Fri, Sep 4, 10:58 PM
Unknown Object (File)
Thu, Sep 3, 12:27 PM
Unknown Object (File)
Thu, Sep 3, 12:25 PM
Unknown Object (File)
Thu, Sep 3, 6:49 AM
Unknown Object (File)
Wed, Sep 2, 1:05 PM
Unknown Object (File)
Wed, Sep 2, 12:57 PM
View All Files
Subscribers
imp

Details

Reviewers
asomers
rwatson
gnn
Commits
rS335284: audit(4): add tests for extattr_get_file(2) and friends
Summary

This revision introduces test-cases for checking the proper auditability of syscalls
concerned with retrieving/listing the extended attributes of a file or a symbolic link.
The system calls are categorized within file-attribute-access audit class.
List of syscalls are:

  • extattr_get_file(2)
  • extattr_get_fd(2)
  • extattr_get_link(2)
  • extattr_list_file(2)
  • extattr_list_fd(2)
  • extattr_list_link(2)
Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17368
Build 17201: arc lint + arc unit

Event Timeline

aniketp created this revision.Jun 17 2018, 12:03 AM
Harbormaster completed remote builds in B17361: Diff 43926.Jun 17 2018, 12:03 AM
aniketp edited the summary of this revision. (Show Details)Jun 17 2018, 12:04 AM
aniketp set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJun 17 2018, 12:04 AM
aniketp edited the test plan for this revision. (Show Details)Jun 17 2018, 12:06 AM
asomers added inline comments.Jun 17 2018, 3:16 AM
tests/sys/audit/file-attribute-access.c
990

Is it necessary to set an extended attribute for the list_file test?

aniketp updated this revision to Diff 43938.Jun 17 2018, 8:14 AM

Setting file attributes is not required for listin them

Harbormaster completed remote builds in B17368: Diff 43938.Jun 17 2018, 8:14 AM
asomers accepted this revision.Jun 17 2018, 3:17 PM
This revision is now accepted and ready to land.Jun 17 2018, 3:17 PM
Closed by commit rS335284: audit(4): add tests for extattr_get_file(2) and friends (authored by asomers). · Explain WhyJun 17 2018, 3:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
tests/
sys/
audit/
351 lines

Diff 43938

View Options

tests/sys/audit/file-attribute-access.c

Loading...