Page MenuHomeFreeBSD
Differential D15839

Correct logic error
ClosedPublic
Actions

Authored by allanjude on Jun 16 2018, 1:47 AM.
Tags
None
Referenced Files
F151240591: D15839.id43859.diff
Tue, Apr 7, 1:42 AM
Unknown Object (File)
Mon, Mar 30, 6:01 AM
Unknown Object (File)
Mon, Mar 30, 6:01 AM
Unknown Object (File)
Sun, Mar 29, 5:49 PM
Unknown Object (File)
Sun, Mar 29, 2:31 AM
Unknown Object (File)
Fri, Mar 27, 12:37 PM
Unknown Object (File)
Thu, Mar 26, 11:10 AM
Unknown Object (File)
Mar 1 2026, 10:08 PM
View All 60 Files
Subscribers
None

Details

Reviewers
imp
tsoome
kevans
• ian
Commits
rS335245: Correct logic error in biosdisk.c:bd_realstrategy()
Summary

While investigating an issue with GELI boot, I found what looks like a logic error. The contents of the if statement are definately meant to run if disk_ioctl successed, but actually only run if it fails. This also results in the 'We should not get here' code running in most cases

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17322
Build 17157: arc lint + arc unit

Event Timeline

allanjude created this revision.Jun 16 2018, 1:47 AM
Harbormaster completed remote builds in B17322: Diff 43859.Jun 16 2018, 1:47 AM
imp accepted this revision.Jun 16 2018, 2:46 AM

Yes sir! We have a winner!

This revision is now accepted and ready to land.Jun 16 2018, 2:46 AM
Closed by commit rS335245: Correct logic error in biosdisk.c:bd_realstrategy() (authored by allanjude). · Explain WhyJun 16 2018, 2:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stand/
i386/
libi386/
4 lines

Diff 43859

View Options

stand/i386/libi386/biosdisk.c

Loading...