Page MenuHomeFreeBSD
Differential D15638

Name the implementation of brk and sbrk sys_break().
ClosedPublic
Actions

Authored by brooks on May 31 2018, 11:28 PM.
Tags
None
Referenced Files
F107194310: D15638.diff
Sat, Jan 11, 11:44 AM
Unknown Object (File)
Nov 22 2024, 4:06 PM
Unknown Object (File)
Nov 19 2024, 11:52 PM
Unknown Object (File)
Nov 13 2024, 7:57 PM
Unknown Object (File)
Sep 23 2024, 4:21 PM
Unknown Object (File)
Sep 16 2024, 6:17 PM
Unknown Object (File)
Sep 10 2024, 1:56 AM
Unknown Object (File)
Sep 8 2024, 6:37 PM
View All 61 Files
Subscribers
imp

Details

Reviewers
kib
jhb
emaste
Commits
rS335177: Name the implementation of brk and sbrk sys_break().
Summary

The break() system call was renamed (several times) starting in v3 AT&T
UNIX when C was invented and break was a language keyword. The last
vestage of a need for it to be called something else (eg obreak) was removed
in r225617 which consistantly prefixed all syscall implementations.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17285
Build 17122: arc lint + arc unit

Event Timeline

brooks created this revision.May 31 2018, 11:28 PM
Harbormaster completed remote builds in B16954: Diff 43221.May 31 2018, 11:28 PM
kib added a comment.Jun 1 2018, 2:07 PM

Don't you miss compat32 ?

sys/vm/vm_unix.c
199

Remove this printf, it is spam.

kib added a comment.Jun 1 2018, 2:11 PM

And capabilities.conf are not handled.

brooks updated this revision to Diff 43249.Jun 1 2018, 5:04 PM
  • Update capabilities.conf.
  • Use sys_break in linux compat.
  • Handle freebsd32 and ibcs.
Harbormaster completed remote builds in B16964: Diff 43249.Jun 1 2018, 5:04 PM
brooks updated this revision to Diff 43454.Jun 8 2018, 1:45 PM
  • Rebase on top of new return.
Harbormaster completed remote builds in B17098: Diff 43454.Jun 8 2018, 1:45 PM
emaste added a comment.Jun 12 2018, 1:58 AM

Change seems sensible to me.

sys/compat/linux/linux_misc.c
245

Change for a later commit -- on IRC @kib pointed this out to me in a different context: we shouldn't be calling the syscall entry point like this, but rather split sys_break into sys_break and kern_break, and call the latter from sys_break and linux_brk.

brooks updated this revision to Diff 43784.Jun 14 2018, 8:38 PM
  • GC a pointless printf.
Harbormaster completed remote builds in B17285: Diff 43784.Jun 14 2018, 8:38 PM
emaste added a comment.Jun 14 2018, 8:51 PM

LGTM

brooks edited the summary of this revision. (Show Details)Jun 14 2018, 8:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 14 2018, 9:27 PM
Closed by commit rS335177: Name the implementation of brk and sbrk sys_break(). (authored by brooks). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJun 14 2018, 9:27 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
freebsd32/
3 lines
linux/
4 lines
i386/
ibcs2/
2 lines
kern/
2 lines
3 lines
vm/
9 lines

Diff 43784

View Options

sys/compat/freebsd32/syscalls.master

Loading...
View Options

sys/compat/linux/linux_misc.c

Loading...
View Options

sys/i386/ibcs2/syscalls.master

Loading...
View Options

sys/kern/capabilities.conf

Loading...
View Options

sys/kern/syscalls.master

Loading...
View Options

sys/vm/vm_unix.c

Loading...