Page MenuHomeFreeBSD

Name the implementation of brk and sbrk sys_break().
ClosedPublic

Authored by brooks on May 31 2018, 11:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 2:46 AM
Unknown Object (File)
Thu, Jan 23, 2:46 AM
Unknown Object (File)
Thu, Jan 23, 2:46 AM
Unknown Object (File)
Thu, Jan 23, 2:45 AM
Unknown Object (File)
Thu, Jan 23, 2:45 AM
Unknown Object (File)
Thu, Jan 23, 2:45 AM
Unknown Object (File)
Wed, Jan 22, 7:05 PM
Unknown Object (File)
Sat, Jan 18, 2:49 PM
Subscribers

Details

Summary

The break() system call was renamed (several times) starting in v3 AT&T
UNIX when C was invented and break was a language keyword. The last
vestage of a need for it to be called something else (eg obreak) was removed
in r225617 which consistantly prefixed all syscall implementations.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16954
Build 16825: arc lint + arc unit

Event Timeline

Don't you miss compat32 ?

sys/vm/vm_unix.c
198

Remove this printf, it is spam.

And capabilities.conf are not handled.

  • Update capabilities.conf.
  • Use sys_break in linux compat.
  • Handle freebsd32 and ibcs.
  • Rebase on top of new return.

Change seems sensible to me.

sys/compat/linux/linux_misc.c
245 ↗(On Diff #43454)

Change for a later commit -- on IRC @kib pointed this out to me in a different context: we shouldn't be calling the syscall entry point like this, but rather split sys_break into sys_break and kern_break, and call the latter from sys_break and linux_brk.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 14 2018, 9:27 PM
This revision was automatically updated to reflect the committed changes.