Page MenuHomeFreeBSD
Differential D15629

Pass a struct devdesc to the format commands. Use proper type rather than doing weird type-punning that happened to work because the size was right :(
ClosedPublic
Actions

Authored by imp on May 30 2018, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 11, 12:49 AM
Unknown Object (File)
Wed, Nov 5, 9:00 PM
Unknown Object (File)
Fri, Oct 17, 5:41 PM
Unknown Object (File)
Fri, Oct 17, 5:41 PM
Unknown Object (File)
Fri, Oct 17, 5:41 PM
Unknown Object (File)
Fri, Oct 17, 5:41 PM
Unknown Object (File)
Fri, Oct 17, 8:59 AM
Unknown Object (File)
Sep 14 2025, 3:48 PM
View All Files
Subscribers
None

Details

Reviewers
rgrimes
dim
kevans
emaste
Group Reviewers
bhyve
Commits
rS334415: Update to device enumeration protocol 2
rS334414: Make the data returned by devinfo harder to overflow.
rS334413: Sanity check the return from the kernel.
rS334412: Pass a struct devdesc to the format commands. Use proper type rather
Summary

This is a fix for an issue found during https://reviews.freebsd.org/D15628

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16932
Build 16809: arc lint + arc unit

Event Timeline

imp created this revision.May 30 2018, 8:59 PM
Herald added a reviewer: rgrimes. · View Herald TranscriptMay 30 2018, 8:59 PM
Harbormaster completed remote builds in B16932: Diff 43176.May 30 2018, 8:59 PM
imp updated this revision to Diff 43177.May 30 2018, 9:05 PM

update.

Harbormaster completed remote builds in B16933: Diff 43177.May 30 2018, 9:05 PM
rgrimes edited the summary of this revision. (Show Details)May 30 2018, 9:42 PM
rgrimes added reviewers: dim, kevans, emaste, bhyve.

Copy over subscribers from D15628 and describe this review as a fix for an issue found during that review.

dim accepted this revision.May 30 2018, 11:00 PM

LGTM now.

This revision is now accepted and ready to land.May 30 2018, 11:00 PM
Closed by commit rS334412: Pass a struct devdesc to the format commands. Use proper type rather (authored by imp). · Explain WhyMay 31 2018, 2:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stand/
userboot/
userboot/
17 lines

Diff 43176

View Options

stand/userboot/userboot/main.c

Loading...