Differential D15629

Pass a struct devdesc to the format commands. Use proper type rather than doing weird type-punning that happened to work because the size was right :(
ClosedPublic
Actions

Authored by imp on May 30 2018, 8:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 8, 6:30 PM

	Unknown Object (File)
	Fri, Feb 27, 10:30 PM

	Unknown Object (File)
	Fri, Feb 27, 11:41 AM

	Unknown Object (File)
	Sat, Feb 21, 5:47 AM

	Unknown Object (File)
	Sun, Feb 8, 3:45 PM

	Unknown Object (File)
	Sun, Feb 8, 2:08 PM

	Unknown Object (File)
	Sun, Feb 8, 2:03 PM

	Unknown Object (File)
	Feb 7 2026, 8:11 AM

Subscribers

None

Details

Reviewers

rgrimes
dim
kevans
emaste

Group Reviewers

Commits

rS334415: Update to device enumeration protocol 2
rS334414: Make the data returned by devinfo harder to overflow.
rS334413: Sanity check the return from the kernel.
rS334412: Pass a struct devdesc to the format commands. Use proper type rather

Summary

This is a fix for an issue found during https://reviews.freebsd.org/D15628

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16932
Build 16809: arc lint + arc unit

Event Timeline

imp created this revision.May 30 2018, 8:59 PM

Herald added a reviewer: rgrimes. · View Herald TranscriptMay 30 2018, 8:59 PM

Harbormaster completed remote builds in B16932: Diff 43176.May 30 2018, 8:59 PM

update.

Harbormaster completed remote builds in B16933: Diff 43177.May 30 2018, 9:05 PM

Copy over subscribers from D15628 and describe this review as a fix for an issue found during that review.

LGTM now.

This revision is now accepted and ready to land.May 30 2018, 11:00 PM

Closed by commit rS334412: Pass a struct devdesc to the format commands. Use proper type rather (authored by imp). · Explain WhyMay 31 2018, 2:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

stand/

userboot/

userboot/

17 lines

Diff 43176

stand/userboot/userboot/main.c

Loading...