Page MenuHomeFreeBSD

Fix "Bad tailq" panic when auditing auditon(A_SETCLASS, ...)
ClosedPublic

Authored by asomers on May 10 2018, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 31, 10:31 AM
Unknown Object (File)
Wed, Oct 22, 11:27 AM
Unknown Object (File)
Sun, Oct 19, 6:35 AM
Unknown Object (File)
Sun, Oct 19, 6:35 AM
Unknown Object (File)
Sat, Oct 18, 6:12 PM
Unknown Object (File)
Sat, Oct 18, 6:12 PM
Unknown Object (File)
Sat, Oct 18, 7:32 AM
Unknown Object (File)
Fri, Oct 17, 4:42 AM
Subscribers

Details

Summary

Fix "Bad tailq" panic when auditing auditon(A_SETCLASS, ...)

Due to an oversight in r195280, auditon(A_SETCLASS, ...) would cause a tailq
element to get added to the tailq twice, resulting in a circular tailq. This
panics when INVARIANTS are on.

Test Plan

Open /dev/auditpipe, set the preselect mode to LOCAL, set the preselect flags
and naflags to include class ad, then start auditd. Some ATF tests in progress
do this (Phabricator D15286).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16516
Build 16430: arc lint + arc unit