Page MenuHomeFreeBSD
Differential D15381

Fix "Bad tailq" panic when auditing auditon(A_SETCLASS, ...)
ClosedPublic
Actions

Authored by asomers on May 10 2018, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 29, 6:28 AM
Unknown Object (File)
Wed, Apr 29, 6:24 AM
Unknown Object (File)
Sun, Apr 26, 11:12 AM
Unknown Object (File)
Mon, Apr 20, 2:29 AM
Unknown Object (File)
Sun, Apr 19, 1:36 PM
Unknown Object (File)
Sun, Apr 19, 5:08 AM
Unknown Object (File)
Mon, Apr 6, 11:26 AM
Unknown Object (File)
Sat, Apr 4, 9:56 PM
View All Files
Subscribers
aniketp
imp

Details

Reviewers
rwatson
gnn
Commits
rS337251: MFC r334296:
rS336207: MFC r334296:
rS334296: Fix "Bad tailq" panic when auditing auditon(A_SETCLASS, ...)
Summary

Fix "Bad tailq" panic when auditing auditon(A_SETCLASS, ...)

Due to an oversight in r195280, auditon(A_SETCLASS, ...) would cause a tailq
element to get added to the tailq twice, resulting in a circular tailq. This
panics when INVARIANTS are on.

Test Plan

Open /dev/auditpipe, set the preselect mode to LOCAL, set the preselect flags
and naflags to include class ad, then start auditd. Some ATF tests in progress
do this (Phabricator D15286).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16516
Build 16430: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
security/
audit/
1 line

Diff 42368

View Options

sys/security/audit/audit_bsm.c

Loading...