Page MenuHomeFreeBSD

aniketp_iitk.ac.in (Aniket Pandey)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 24 2018, 4:03 PM (326 w, 2 d)

Recent Activity

Jun 1 2018

aniketp_iitk.ac.in abandoned D15649: Add tests for 3 syscalls in "file-close" audit class.
Jun 1 2018, 10:35 PM
aniketp_iitk.ac.in created D15649: Add tests for 3 syscalls in "file-close" audit class.
Jun 1 2018, 10:34 PM

May 29 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Changes as suggested in the above inline comments.

May 29 2018, 10:38 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Initialize nomask before dereferencing it

May 29 2018, 8:33 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Correct the placement of

	/* Set local preselection audit_class as "no" for audit startup */
	set_preselect_mode(fd[0].fd, &nomask);
May 29 2018, 8:27 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Improvements in some comments of set_preselect_mode function

May 29 2018, 8:25 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.
  • Include a perror("au_read_rec") for a better insight into incomplete audit record failure (If any)
  • Remove redundant header sys/syscall.h
  • Introduce a "no" audit class specifically for audit startup.
May 29 2018, 8:11 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

After a long period of debugging the incomplete audit record issue, which was fixed by D15381, this update introduces the following changes

May 29 2018, 4:20 PM

May 14 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Update the atf_tc_fail message for ppoll(2) timeout in check_auditpipe function to show the audit regex which caused the tests to fail (timeout).

May 14 2018, 4:48 PM

May 13 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.
  • Remove ATF_REQUIRE condition from au_read_rec since reading extraneous corrupted records from auditpipe might not be successful always
  • Call set_preselect_mode twice, once for audit startup and another for syscall audit
  • print warning statement in case "au_fetch_tok" returns incomplete audit record
May 13 2018, 5:12 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Remove if condition check from au_fetch_tok as it is possible that final audit tokens are not complete and are not required as well. There is no need to fail the tests in such scenario.

May 13 2018, 2:18 PM

May 12 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Add ATF_REQUIRE check on au_read_rec(3) function. Also, some formatting changes.

May 12 2018, 5:53 PM

May 11 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Revert back to using reclen-bytes as the third argument of au_fetch_tok instead of reclen to avoid buffer overrun.

May 11 2018, 9:21 PM
aniketp_iitk.ac.in added inline comments to D15286: Add initial set of tests for audit(4) subsystem.
May 11 2018, 8:46 PM
aniketp_iitk.ac.in added inline comments to D15286: Add initial set of tests for audit(4) subsystem.
May 11 2018, 8:18 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Fix for the intermittent issue "failed: incomplete audit record". Also, clean any outstanding auditpipe buffer after audit startup is emitted from auditpipe

May 11 2018, 7:39 PM

May 10 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.
  • Shift set_preselect_mode call post to "audit startup" as the tests failed when auditd(8) was already running.
May 10 2018, 7:43 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Set of corrections in utils.c :

  • Remove am_failure flag for "ad" audit class
  • Remove extraneous boolean flag
  • Shift set_preselect_mode to before audit startup to avoid race condition
  • Additional changes in code sematics
May 10 2018, 6:18 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.
  • Fix the "audit startup" issue by looping within the "check_audit_startup" function to eliminate any unwanted events that might have been logged before audit startup.
  • Define two wrapper functions check_audit_startup and check_audit around a static function check_auditpipe.
May 10 2018, 5:33 PM

May 9 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Remove the redundant line SRCS.file-create+= file-create.c from Makefile.

May 9 2018, 10:59 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Revert the accidental addition of curly braces from single line if statements.

May 9 2018, 10:23 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Replace spaces with tabs at a couple of places

May 9 2018, 10:11 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Remove the braces for single line if statements according to style(9) from functions:

  • FILE *setup
  • static void set_preselect_mode
May 9 2018, 9:56 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Update: Add the local preselection flag for non-attributable events
AUDITPIPE_SET_PRESELECT_NAFLAGS

May 9 2018, 8:43 PM

May 7 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Few corrections in the formatting of source program. The current changes did not seem to affect the result for me.

file-create:link_failure  ->  passed  [0.023s]
file-create:link_success  ->  passed  [0.022s]
file-create:linkat_failure  ->  passed  [0.023s]
file-create:linkat_success  ->  passed  [0.023s]
file-create:mkdir_failure  ->  passed  [0.024s]
file-create:mkdir_success  ->  passed  [0.026s]
file-create:mkdirat_failure  ->  passed  [0.026s]
file-create:mkdirat_success  ->  passed  [0.023s]
file-create:mkfifo_failure  ->  passed  [0.023s]
file-create:mkfifo_success  ->  passed  [0.028s]
file-create:mkfifoat_failure  ->  passed  [0.027s]
file-create:mkfifoat_success  ->  passed  [0.023s]
file-create:mknod_failure  ->  passed  [0.022s]
file-create:mknod_success  ->  passed  [0.022s]
file-create:mknodat_failure  ->  passed  [0.023s]
file-create:mknodat_success  ->  passed  [0.023s]
file-create:rename_failure  ->  passed  [0.022s]
file-create:rename_success  ->  passed  [0.023s]
file-create:renameat_failure  ->  passed  [0.023s]
file-create:renameat_success  ->  passed  [0.025s]
file-create:symlink_failure  ->  passed  [0.024s]
file-create:symlink_success  ->  passed  [0.023s]
file-create:symlinkat_failure  ->  passed  [0.025s]
file-create:symlinkat_success  ->  passed  [0.022s]
May 7 2018, 1:03 AM

May 6 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Set the test-case metadata "required_user" as root in Makefile:

TEST_METADATA.file-create+= required_user="root"

and remove atf_tc_set_md_var(tc, "require.user", "root"); from the head of individual test-case since each one of them require root user privileges

May 6 2018, 9:58 PM

May 4 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

This diff introduces following changes:

  • Rename setup.c/h to utils.c/h
  • Introduce a new struct timespec variable timeout to keep track of remaining time while polling.
  • Skip the tests in case the user is not root
  • Remove BUFFLEN from utils.h and a few indentation fixes
May 4 2018, 3:59 PM
aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.

Set of changes as requested by @asomers

  • Sorted the header files, corrected 8 hard tab formatting and other changes according to style(9)
  • Removed redundant type casting (const char *)
  • Corrections in comments and valid variable naming.
May 4 2018, 12:48 PM
aniketp_iitk.ac.in added inline comments to D15286: Add initial set of tests for audit(4) subsystem.
May 4 2018, 12:32 PM
aniketp_iitk.ac.in added inline comments to D15286: Add initial set of tests for audit(4) subsystem.
May 4 2018, 11:32 AM

May 3 2018

aniketp_iitk.ac.in updated the diff for D15286: Add initial set of tests for audit(4) subsystem.
May 3 2018, 9:48 PM
aniketp_iitk.ac.in updated the summary of D15286: Add initial set of tests for audit(4) subsystem.
May 3 2018, 9:39 PM
aniketp_iitk.ac.in created D15286: Add initial set of tests for audit(4) subsystem.
May 3 2018, 9:32 PM